Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prom: Handle channel attribute name changes and fix msat conversion #459

Closed
wants to merge 3 commits into from

Conversation

bleetube
Copy link

@bleetube bleetube commented Jun 23, 2023

This is my own swing at #451

I noticed that to_satoshi() was a method defined in pyln-client for the Millisatoshi type, so I made sure to cast values as that type so the conversion works as intended.

This closes #450 which was due to changes in various attribute names for the v23.05 release of CLN.

@cdecker
Copy link
Contributor

cdecker commented Jul 20, 2023

Thanks for the PR, I fixed up #451 and we should be good for now, but in case you want to test things locally you can try out the following command:

python3 .ci/test.py prometheus

This will limit the CI runner to the prometheus directory. For each plugin in the CI run the runner will:

  1. Determine whether it is a Python/requirements.txt or a Python/Poetry plugin (skipping if it is neither for the moment, but support for non-python plugins is definitely planned).
  2. Create a virtualenv to install the dependencies in and to run the tests in
  3. Install additional packages we determine to be useful (pytest, pytest-timeout, ...)
  4. Run the pytest tests in the virtualenv

We use virtualenvs extensively in CI in the hopes of creating a reproducible environment that devs can also run locally.

@bleetube bleetube closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus: update for CLN v23.05 with msat purge
2 participants