feat: add emitter event on location change #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chybisov
requested changes
Sep 20, 2024
packages/widget/src/types/events.ts
Outdated
| @@ -30,6 +31,7 @@ export type WidgetEvents = { | |||
| reviewTransactionPageEntered?: Route; | |||
| walletConnected: WalletConnected; | |||
| widgetExpanded: boolean; | |||
| page: string; | |||
There was a problem hiding this comment.
Let's create a union type from navigationRoutes constant instead of string that lists all relevant pages we would like to track, except maybe home? Let me please know what do you think :)
There was a problem hiding this comment.
Good idea! I have re-used the existing NavigationRouteType.
Just not sure with this: To silence ts, I have used it that way here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://lifi.atlassian.net/browse/LF-10006