chore: add import sort order to eslint #234
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: LF-7839
First attempt was using the eslint-plugin-simple-import-sort package. It did autofix but main issues where..
The end solution using a mix of
sort-imports
andeslint-plugin-import
This PR is using a mix of eslints built in
sort-imports
and theeslint-plugin-import
that we already have in the codebase.sort-import
handles the sorting of named imports and the plugin does the rest. Also import statements without variable assignment are ignored. It should autofix imports too.