LPS-173179 Create UI for start of new FDS View creation #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 7 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-173179 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#6090 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#3012 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#2888 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#3460 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3012 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - markocikos > liferay-frontend - PR#3012 - 2023-01-30[07:05:24] Testray Importer:publish-testray-report#7944 |
|
ci:test:relevant |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6063 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#3012 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - markocikos > liferay-frontend - PR#3012 - 2023-01-31[02:29:02] Testray Importer:publish-testray-report#13362 |
|
ci:test:relevant |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-173179 1 Successful Jobs:For more details click here. |
|
All required test suite(s) passed. |
|
Unexpected errors occurred while attempting to forward pull request to 'brianchandotcom'. Retrying in 1 minute... |
2 similar comments
|
Unexpected errors occurred while attempting to forward pull request to 'brianchandotcom'. Retrying in 1 minute... |
|
Unexpected errors occurred while attempting to forward pull request to 'brianchandotcom'. Retrying in 1 minute... |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#129563 |
|
Jenkins Build:test-portal-source-format#5776 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#3012 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#3703 |
|
ci:test:objects |
|
The test suite specified is not a valid test suite. ci:test[:suite][:SHA|nocompile|norebase|gist-SHA]Test the pull request. Optionally specify the name of the test suite and/or optionally specify the upstream SHA to test against or use "nocompile" to test with a prebuilt bundle or use "norebase" to test without rebasing. Available test suites:
|
|
ci:test:object:norebase |
|
The test will run without rebasing. |
|
ci:test:object |
liferay-continuous-integration
added
ci:test:object - pending
ci:test:object - failure
and removed
ci:test:object - pending
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6113 Jenkins Report:jenkins-report.html Jenkins Suite:object Pull Request:liferay-frontend#3012 Testray Routine:EE Pull Request Testray Build:[master] ci:test:object - markocikos > liferay-frontend - PR#3012 - 2023-02-01[10:12:16] Testray Importer:publish-testray-report#13451 |
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
What is the goal of this PR?
In this PR:
onClickon items. Without it, we would be limited to FDS-specific and limited modal. With it, we can useopenModaland customize it as we like.Notes:
onClickto creation button in this PRWhat does it look like?
screen.mp4
Steps to reproduce
feature.flag.LPS-164563=truetoportal-ext.properties