"Practice with computer" defaults the player to white (and computer to black) in Racing Kings games #14116

[GideonPotok]

See conversation in discord: https://discord.com/channels/280713822073913354/352976626558042122/1215336087292223488

https://discord.com/channels/280713822073913354/352976626558042122/1215674696905924658

Before and After: Local (After code change) and Lichess.org (which is before code change)

Original Issue:

Exact URL of where the bug happened

https://lichess.org/rBvFqWnG

Steps to reproduce the bug

Play a Racing Kings game as black
Load the game in analysis view.
Attempt to "Practice with computer" from some point in the game
What did you expect to happen?

I should be playing the black pieces, and the computer playing white.

What happened instead?

I am playing the white pieces, and the computer is playing black.

Operating system

Windows 11

Browser and version (or alternate access method)

Chrome 119

Additional information

The "Practice with computer" feature appears to select which color is played by player and which by computer based on board orientation. Racing Kings flips the board orientation to white no matter which color you are playing, so when you click "Practice with computer" it has you play white.

You can get around this by manually flipping the board, but then everything is upside down. When my opponent resigns/runs out of time I often like to play the rest of the game out against the computer, and it would be nice to be able to do that in the normal orientation when I'm playing Racing Kings as black.

[fitztrev]

Thanks for working on this. Is there still something you're working on for it?

Edit: Also looks like there's another open PR (#14253) for the same issue.

[ross39]

@fitztrev I made that pr a long time ago as a fix for that issue. I can retest it to make sure it still works.

[GideonPotok]

@fitztrev @ross39

Due to technical issues, this PR is not such an easy win as it seemed. It is hard to make work.

@fitztrev regarding your PR #14253, I found that AnalyseCtrl.data.game.player was unreliable sometimes.