-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Feature] Integer scaling and super resolution #485
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging 204b64a into 500c8ba - view on LGTM.com new alerts:
|
Update: Added support to unicode font. A |
Update: Refactorred |
Update: Nowadays people are usually not willing to change their resolution once a neat one has been set, and the largest resolution is not always best (especially for CRTs). This commit makes Ludo use current desktop resolution when entering full-screen mode. |
@donmor That last commit gold ⭐ Ludo changes the resolution from 1920x1080 to 1920x1200 when connected to my capture card, which introduces screen clipping and refresh rate desync. Thanks for the patch. |
But this last commit breaks full screen on OSX |
Hmmmmmm... Maybe a macro.could help (does go have macros?) or a statement block? |
I think it's also likely to break fullscreen elsewhere. If I recall correctly API of GLFW wants a monitor to be passed to achieve full screen. |
Gosh I've not even had a mac and my windows pc's wonky :( |
Finally I managed to fix the fullscreen mode on linux, and'll test on windows later. So does anyone have a mac here? |
Okay please wait for a while before I put some comments in code :) |
BTW I think it'd be better to use unicode font glyph instead ascii, as the first step to making i18n stuff. |
Former issue #483 .
This PR added a feature that making it able to do integer scaling, to achieve "pixel perfect". When option
Settings > Video Integer Scaling
is on, the core renderer detects the window size and scale the original video to the max size while keeping pixel-perfect. An entry added in settings.