HTTP Proxy support #295
Open
HTTP Proxy support #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, just what i needed in my envoirment too, |
sstidl
requested changes
Nov 4, 2023
| @@ -79,11 +79,15 @@ function getIpInfoTokenString(){ | |||
| if(empty($IPINFO_APIKEY)) return ""; | |||
| return "?token=".$IPINFO_APIKEY; | |||
| } | |||
| $httpproxyFile="getIP_ipInfo_httpproxy.php"; | |||
| if (!file_exists($httpproxyFile)) return ""; | |||
There was a problem hiding this comment.
Why return here?
The missing file should be handled as if no proxy defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I logged a issue #289 as https://ipinfo.io/ request would time out, This was causing the speedtest to hang for 60 seconds before it would start. HTTP/HTTPS is blocked in my environments and we are forced to make web requests via http proxy. Setting the system proxy fails to make any difference on my web servers.
As such, I have created proxy support in my fork.
Tested with proxy address set and blank, OK.
PS, I'm a sys admin, not a dev.