Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in the display and search of data. #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diegocanton
Copy link

Displays "sysname";
Make port names and devices capitalized, making the search easier;

Displays "sysname";
Make port names and devices capitalized, making the search easier;
xbeaudouin added a commit to xbeaudouin/Weathermap that referenced this pull request Nov 2, 2022
@electrocret
Copy link

electrocret commented Nov 23, 2022

I tested this, and this works great!

My only thought for improvment would be for Weathermap to somehow display based on what Libre's "device_display_default" setting is set to.

To test - As Libre user:

cd <librenms_dir>/html/plugins/Weathermap
curl -s https://patch-diff.githubusercontent.com/raw/librenms-plugins/Weathermap/pull/87.diff | git apply --exclude=*.png -v

@diegocanton diegocanton reopened this Nov 25, 2022
@diegocanton
Copy link
Author

I liked your idea. I'll look for a way to do it and apply it to a new Pull order, when it's applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants