Adding a fix to allow IPv6 addresses by replacing ":" with underscore #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementPrimot
changed the title
xbeaudouin
added a commit
to xbeaudouin/Weathermap
that referenced
this pull request
Nov 2, 2022
BarbarossaTM
approved these changes
Apr 16, 2023
There was a problem hiding this comment.
This is neat, thanks!
Kudos to @pfromme25 for testing this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the conception of our weathermap @ Telerys Communication, we noticed that devices's RRD with IPv6 addresses are stored with this format: XXXX_XXXX_XXXX_XXXX.
PHP Weathermap use ":" instead of "_".
This fix replaces ":" by "_" to allow the usage of IPv6 devices with PHP Weathermap.