This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
only include rack.processes if rack suite enabled
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @samandmoore Thanks for your contribution! As proposed in #74, this looks good to me. 👍 We have existing tests for the suites feature, however we'll want to make sure a new test lands in tracker instead so we can ensure your fix is not unintentionally broken in the future. I can follow up and add that. |
Merged
|
Released in |
|
Thank you!
…On Fri, Jun 23, 2017 at 17:32 Chance Feick ***@***.***> wrote:
Released in v2.0.3. Thanks for your contribution, @samandmoore
<https://github.com/samandmoore>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAY4IgsvQ9qhblPLy3oGRQNnri08OATXks5sHC7WgaJpZM4N9pfT>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I opened an issue for this about a month ago (#74), and now I'd like to propose a change that will make the
rack.processesmetric a part of theracksuite.This PR includes the diff for that change. I did not add any tests because I didn't see any equivalent tests. I'd be happy to add one if you deem it necessary and have some guidance on how you'd like to see that tested.
Thanks for your time!