Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

highlight tagged metrics breaking change #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niklibrato
Copy link

@nextmat
Copy link
Contributor

nextmat commented Mar 10, 2017

I don't think this version actually does introduce any breaking changes for this gem, although this is true for lib-rack and lib-rails. @chancefeick ?

@@ -1,7 +1,7 @@
## Changelog

### Version 2.1.0
* Add support for tagged measurements (#121)
* Add support for tagged measurements (#121). **NOTE**: This version introduces breaking changes for legacy sources. Please contact [email protected] to learn more.
Copy link
Contributor

@chancefeick chancefeick Mar 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit misleading, as you can still use sources but not tags unless it's enabled. Breaking changes only seem applicable to librato-rails and librato-rack, which uses either tags or sources.

Can you reword this to reflect that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants