Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

V2 references Faraday::Error::ConnectionFailed, which doesn't exist in newer versions of Faraday #144

Open
patbl opened this issue Jul 30, 2021 · 0 comments

Comments

@patbl
Copy link

patbl commented Jul 30, 2021

A long time ago, Faraday::Error::ConnectionFailed was moved to Faraday::ConnectionFailed. This mismatch results in the following error:

Check failed to run: uninitialized constant Faraday::Error::ConnectionFailed
Did you mean?  Faraday::ConnectionFailed

Here's the line that raises the exception: https://github.com/librato/librato-metrics/blob/v2.1.2/lib/librato/metrics/middleware/retry.rb#L19

The error class was updated on the 1.x branch here, but the 2.x branch still uses the old class.

patbl added a commit to academia-edu/librato-metrics that referenced this issue Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant