Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Commit

Permalink
Use correct namespace for ConnectionFailed Faraday error
Browse files Browse the repository at this point in the history
See librato#144 for more info.
  • Loading branch information
patbl committed Jul 30, 2021
1 parent a362719 commit e1bedc2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/librato/metrics/middleware/retry.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def call(env)
env[:body] = request_body # after failure is set to response body
@app.call(env)
rescue Librato::Metrics::ServerError, Timeout::Error,
Faraday::Error::ConnectionFailed
Faraday::ConnectionFailed

This comment has been minimized.

Copy link
@aristocrates

aristocrates Jul 30, 2021

@patbl Should there also be a min version constraint added to faraday in the gemspec with this change? lostisland/faraday@a6c6f16 added this between 0.8.11 and 0.9.0.rc1 lostisland/faraday@v0.8.11...v0.9.0.rc1

This comment has been minimized.

Copy link
@patbl

patbl Aug 2, 2021

Author

Ja, that makes sense

if retries > 0
retries -= 1 and retry
end
Expand All @@ -28,4 +28,4 @@ def call(env)

end
end
end
end

0 comments on commit e1bedc2

Please sign in to comment.