Merge pull request #119 from librato/chore/remove-1-8-support

Remove support for ruby 1.8

.travis.yml

@@ -2,8 +2,6 @@
 sudo: false
 
 rvm:
-  # - 1.8.7
-  # - ree
   - 1.9.3
   - 2.1.7
   - 2.2.3
@@ -23,4 +21,4 @@ branches:
 notifications:
   email:
     on_failure: change
-    on_success: never
+    on_success: never

Gemfile

@@ -32,4 +32,5 @@ group :test do
   gem 'rspec', '~> 3.5.0'
   gem 'sinatra'
   gem 'popen4'
+  gem 'multi_json'
 end

README.md

@@ -32,11 +32,11 @@ If you are using jruby, you need to ensure [jruby-openssl](https://github.com/jr
 If you are looking for the quickest possible route to getting a data into Metrics, you only need two lines:
 
     Librato::Metrics.authenticate 'email', 'api_key'
-    Librato::Metrics.submit :my_metric => 42, :my_other_metric => 1002
+    Librato::Metrics.submit my_metric: 42, my_other_metric: 1002
 
 Unspecified metrics will send a *gauge*, but if you need to send a different metric type or include additional properties, simply use a hash:
 
-    Librato::Metrics.submit :my_metric => {:type => :counter, :value => 1002, :source => 'myapp'}
+    Librato::Metrics.submit my_metric: {type: :counter, value: 1002, source: 'myapp'}
 
 While this is all you need to get started, if you are sending a number of metrics regularly a queue may be easier/more performant so read on...
 
@@ -53,7 +53,7 @@ If you are sending very many measurements or sending them very often, it will be
 Queue up a simple gauge metric named `temperature`:
 
     queue = Librato::Metrics::Queue.new
-    queue.add :temperature => 32.2
+    queue.add temperature: 32.2
 
 While symbols are used by convention for metric names, strings will work just as well:
 
@@ -64,18 +64,18 @@ If you are tracking measurements over several seconds/minutes, the queue will ha
 If you want to specify a time other than queuing time for the measurement:
 
 	# use a epoch integer
-	queue.add :humidity => {:measure_time => 1336508422, :value => 48.2}
+	queue.add humidity: {measure_time: 1336508422, value: 48.2}
 
 	# use a Time object to correct for a 5 second delay
-	queue.add :humidity => {:measure_time => Time.now-5, :value => 37.6}
+	queue.add humidity: {measure_time: Time.now-5, value: 37.6}
 
 You can queue multiple metrics at once. Here's a gauge (`load`) and a counter (`visits`):
 
-    queue.add :load => 2.2, :visits => {:type => :counter, :value => 400}
+    queue.add load: 2.2, visits: {type: :counter, value: 400}
 
 Queue up a metric with a specified source:
 
-    queue.add :cpu => {:source => 'app1', :value => 92.6}
+    queue.add cpu: {source: 'app1', value: 92.6}
 
 A complete [list of metric attributes](http://dev.librato.com/v1/metrics) is available in the [API documentation](http://dev.librato.com/v1).
 
@@ -90,23 +90,23 @@ If you are measuring something very frequently e.g. per-request in a web applica
 Aggregate a simple gauge metric named `response_latency`:
 
     aggregator = Librato::Metrics::Aggregator.new
-    aggregator.add :response_latency => 85.0
-    aggregator.add :response_latency => 100.5
-    aggregator.add :response_latency => 150.2
-    aggregator.add :response_latency => 90.1
-    aggregator.add :response_latency => 92.0
+    aggregator.add response_latency: 85.0
+    aggregator.add response_latency: 100.5
+    aggregator.add response_latency: 150.2
+    aggregator.add response_latency: 90.1
+    aggregator.add response_latency: 92.0
 
 Which would result in a gauge measurement like:
 
-    {:name => "response_latency", :count => 5, :sum => 517.8, :min => 85.0, :max => 150.2}
+    {name: "response_latency", count: 5, sum: 517.8, min: 85.0, max: 150.2}
 
 You can specify a source during aggregate construction:
 
-    aggregator = Librato::Metrics::Aggregator.new(:source => 'foobar')
+    aggregator = Librato::Metrics::Aggregator.new(source: 'foobar')
 
 You can aggregate multiple metrics at once:
 
-    aggregator.add :app_latency => 35.2, :db_latency => 120.7
+    aggregator.add app_latency: 35.2, db_latency: 120.7
 
 Send the currently aggregated metrics to Metrics:
 
@@ -124,7 +124,7 @@ The difference between the two is that `Queue` submits each timing measurement i
 
 If you need extra attributes for a `Queue` timing measurement, simply add them on:
 
-    queue.time :my_measurement, :source => 'app1' do
+    queue.time :my_measurement, source: 'app1' do
       # do work...
     end
 
@@ -138,9 +138,9 @@ At a minimum each annotation needs to be assigned to a stream and to have a titl
 
 There are a number of optional fields which can make annotations even more powerful:
 
-    Librato::Metrics.annotate :deployments, 'deployed v46', :source => 'frontend',
-        :start_time => 1354662596, :end_time => 1354662608,
-        :description => 'Deployed 6f3bc6e67682: fix lotsa bugs…'
+    Librato::Metrics.annotate :deployments, 'deployed v46', source: 'frontend',
+        start_time: 1354662596, end_time: 1354662608,
+        description: 'Deployed 6f3bc6e67682: fix lotsa bugs…'
 
 You can also automatically annotate the start and end time of an action by using `annotate`'s block form:
 
@@ -156,7 +156,7 @@ More fine-grained control of annotations is available via the `Annotator` object
     streams = annotator.list
 
     # fetch a list of events in the last hour from a stream
-    annotator.fetch :deployments, :start_time => (Time.now.to_i-3600)
+    annotator.fetch :deployments, start_time: (Time.now.to_i-3600)
 
     # delete an event
     annotator.delete_event 'deployments', 23
@@ -168,15 +168,15 @@ See the documentation of `Annotator` for more details and examples of use.
 Both `Queue` and `Aggregator` support automatically submitting measurements on a given time interval:
 
 	# submit once per minute
-	timed_queue = Librato::Metrics::Queue.new(:autosubmit_interval => 60)
+	timed_queue = Librato::Metrics::Queue.new(autosubmit_interval: 60)
 
 	# submit every 5 minutes
-	timed_aggregator = Librato::Metrics::Aggregator.new(:autosubmit_interval => 300)
+	timed_aggregator = Librato::Metrics::Aggregator.new(autosubmit_interval: 300)
 
 `Queue` also supports auto-submission based on measurement volume:
 
 	# submit when the 400th measurement is queued
-	volume_queue = Librato::Metrics::Queue.new(:autosubmit_count => 400)
+	volume_queue = Librato::Metrics::Queue.new(autosubmit_count: 400)
 
 These options can also be combined for more flexible behavior.
 
@@ -192,7 +192,7 @@ Get name and properties for all metrics you have in the system:
 
 Get only metrics whose name includes `time`:
 
-    metrics = Librato::Metrics.metrics :name => 'time'
+    metrics = Librato::Metrics.metrics name: 'time'
 
 ## Querying Metric Data
 
@@ -202,19 +202,19 @@ Get attributes for metric `temperature`:
 
 Get the 20 most recent data points for `temperature`:
 
-    data = Librato::Metrics.get_measurements :temperature, :count => 20
+    data = Librato::Metrics.get_measurements :temperature, count: 20
 
 Get the 20 most recent data points for `temperature` from a specific source:
 
-    data = Librato::Metrics.get_measurements :temperature, :count => 20, :source => 'app1'
+    data = Librato::Metrics.get_measurements :temperature, count: 20, source: 'app1'
 
 Get the 20 most recent 15 minute data point rollups for `temperature`:
 
-    data = Librato::Metrics.get_measurements :temperature, :count => 20, :resolution => 900
+    data = Librato::Metrics.get_measurements :temperature, count: 20, resolution: 900
 
 Get the 5 minute moving average for `temperature` for the last hour, assuming temperature is submitted once per minute:
 
-    data = Librato::Metrics.get_composite 'moving_average(mean(series("temperature", "*"), {size: "5"}))', :start_time => Time.now.to_i - 60*60, :resolution => 300
+    data = Librato::Metrics.get_composite 'moving_average(mean(series("temperature", "*"), {size: "5"}))', start_time: Time.now.to_i - 60*60, resolution: 300
 
 There are many more options supported for querying, take a look at the [REST API docs](http://dev.librato.com/v1/get/metrics/:name) or the individual method documentation for more details.
 
@@ -223,7 +223,7 @@ There are many more options supported for querying, take a look at the [REST API
 Setting custom [properties](http://dev.librato.com/v1/metrics#metric_properties) on your metrics is easy:
 
     # assign a period and default color
-    Librato::Metrics.update_metric :temperature, :period => 15, :attributes => { :color => 'F00' }
+    Librato::Metrics.update_metric :temperature, period: 15, attributes: { color: 'F00' }
 
 It is also possible to update properties for multiple metrics at once, see the [`#update_metric` method documentation](http://rubydoc.info/github/librato/librato-metrics/master/Librato/Metrics/Client#update_metric-instance_method) for more information.
 
@@ -237,7 +237,7 @@ If you ever need to remove a metric and all of its measurements, doing so is eas
 You can also delete using wildcards:
 
     # delete metrics that start with cpu. except for cpu.free
-    Librato::Metrics.delete_metrics :names => 'cpu.*', :exclude => ['cpu.free']
+    Librato::Metrics.delete_metrics names: 'cpu.*', exclude: ['cpu.free']
 
 Note that deleted metrics and their measurements are unrecoverable, so use with care.
 
@@ -257,17 +257,17 @@ All of the same operations you can call directly from `Librato::Metrics` are ava
 	joe.metrics
 
 	# fetch the last 20 data points for Mike's metric, humidity
-	mike.get_measurements :humidity, :count => 20
+	mike.get_measurements :humidity, count: 20
 
 There are two ways to associate a new queue with a client:
 
 	# these are functionally equivalent
-	joe_queue = Librato::Metrics::Queue.new(:client => joe)
+	joe_queue = Librato::Metrics::Queue.new(client: joe)
 	joe_queue = joe.new_queue
 
 Once the queue is associated you can use it normally:
 
-	joe_queue.add :temperature => {:source => 'sf', :value => 65.2}
+	joe_queue.add temperature: {source: 'sf', value: 65.2}
 	joe_queue.submit
 
 ## Thread Safety

Rakefile

@@ -45,8 +45,8 @@ namespace :spec do
   end
 end
 
-task :default => :spec
-task :test => :spec
+task default: :spec
+task test: :spec
 
 # Docs
 require 'yard'
@@ -61,4 +61,3 @@ task :console do
     sh "irb -rubygems -r ./lib/librato/metrics.rb"
   end
 end
-

examples/simple.rb

@@ -3,22 +3,22 @@
 Librato::Metrics.authenticate 'my email', 'my api key'
 
 # send a measurement of 12 for 'foo'
-Librato::Metrics.submit :cpu => 54
+Librato::Metrics.submit cpu: 54
 
 # submit multiple metrics at once
-Librato::Metrics.submit :cpu => 63, :memory => 213
+Librato::Metrics.submit cpu: 63, memory: 213
 
 # submit a metric with a custom source
-Librato::Metrics.submit :cpu => {:source => 'myapp', :value => 75}
+Librato::Metrics.submit cpu: {source: 'myapp', value: 75}
 
 # if you are sending many metrics it is much more performant
 # to submit them in sets rather than individually:
 
 queue = Librato::Metrics::Queue.new
 
 queue.add 'disk.free' => 1223121
-queue.add :memory => 2321
-queue.add :cpu => {:source => 'myapp', :value => 52}
+queue.add memory: 2321
+queue.add cpu: {source: 'myapp', value: 52}
 #...
 
 queue.submit

lib/librato/metrics.rb

@@ -29,17 +29,17 @@ module Librato
   #   Librato::Metrics.metrics
   #
   #   # submit a metric immediately
-  #   Librato::Metrics.submit :foo => 12712
+  #   Librato::Metrics.submit foo: 12712
   #
   #   # fetch the last 10 values of foo
-  #   Librato::Metrics.get_measurements :foo, :count => 10
+  #   Librato::Metrics.get_measurements :foo, count: 10
   #
   # @example Queuing metrics for submission
   #   queue = Librato::Metrics::Queue.new
   #
   #   # queue some metrics
-  #   queue.add :foo => 12312
-  #   queue.add :bar => 45678
+  #   queue.add foo: 12312
+  #   queue.add bar: 45678
   #
   #   # send the metrics
   #   queue.submit
@@ -55,8 +55,8 @@ module Librato
   #   queue = client.new_queue
   #
   #   # queue up some metrics and submit
-  #   queue.add :foo => 12345
-  #   queue.add :bar => 45678
+  #   queue.add foo: 12345
+  #   queue.add bar: 45678
   #   queue.submit
   #
   # @note Most of the methods you can call directly on Librato::Metrics are

lib/librato/metrics/aggregator.rb

@@ -97,20 +97,20 @@ def queued
             metric, source = metric.split(SOURCE_SEPARATOR)
           end
           entry = {
-            :name => metric,
-            :count => data.count,
-            :sum => data.sum,
+            name: metric,
+            count: data.count,
+            sum: data.sum,
 
             # TODO: make float/non-float consistent in the gem
-            :min => data.min.to_f,
-            :max => data.max.to_f
+            min: data.min.to_f,
+            max: data.max.to_f
             # TODO: expose v.sum2 and include
           }
           entry[:source] = source if source
           gauges << entry
         end
 
-        req = { :gauges => gauges }
+        req = { gauges: gauges }
         req[:source] = @source if @source
         req[:measure_time] = @measure_time if @measure_time
 

lib/librato/metrics/annotator.rb

@@ -14,15 +14,15 @@ def initialize(options={})
     #   annotator.add :deployments, 'deployed v45'
     #
     # @example Annotation with start and end times
-    #   annotator.add :deployments, 'deployed v56', :start_time => start,
-    #                 :end_time => end_time
+    #   annotator.add :deployments, 'deployed v56', start_time: start,
+    #                 end_time: end_time
     #
     # @example Annotation with a specific source
-    #   annotator.add :deployments, 'deployed v60', :source => 'app12'
+    #   annotator.add :deployments, 'deployed v60', source: 'app12'
     #
     # @example Annotation with a description
     #   annotator.add :deployments, 'deployed v61',
-    #                 :description => '9b562b2: shipped new feature foo!'
+    #                 description: '9b562b2: shipped new feature foo!'
     #
     # @example Annotate with automatic start and end times
     #   annotator.add(:deployments, 'deployed v62') do
@@ -41,7 +41,7 @@ def add(stream, title, options={})
       event = SmartJSON.read(response.body)
       if block_given?
         yield
-        update_event stream, event['id'], :end_time => Time.now.to_i
+        update_event stream, event['id'], end_time: Time.now.to_i
         # need to get updated representation
         event = fetch_event stream, event['id']
       end
@@ -85,12 +85,12 @@ def delete_event(stream, id)
     #   annotator.fetch :deployments
     #
     # @example Get events on 'deployments' between start and end times
-    #   annotator.fetch :deployments, :start_time => start,
-    #                   :end_time => end_time
+    #   annotator.fetch :deployments, start_time: start,
+    #                   end_time: end_time
     #
     # @example Source-limited listing
-    #   annotator.fetch :deployments, :sources => ['foo','bar','baz'],
-    #                   :start_time => start, :end_time => end_time
+    #   annotator.fetch :deployments, sources: ['foo','bar','baz'],
+    #                   start_time: start, end_time: end_time
     #
     def fetch(stream, options={})
       response = connection.get("annotations/#{stream}", options)
@@ -113,7 +113,7 @@ def fetch_event(stream, id)
     #   streams = annotator.list
     #
     # @example List annotator streams with 'deploy' in the name
-    #   deploy_streams = annotator.list :name => 'deploy'
+    #   deploy_streams = annotator.list name: 'deploy'
     #
     def list(options={})
       response = connection.get("annotations", options)
@@ -123,7 +123,7 @@ def list(options={})
     # Update an event's properties
     #
     # @example Set an end time for a previously submitted event
-    #   annotator.update_event 'deploys', 'v24', :end_time => end_time
+    #   annotator.update_event 'deploys', 'v24', end_time: end_time
     #
     def update_event(stream, id, options={})
       url = "annotations/#{stream}/#{id}"