Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

NH-24785 - Updated gRPC with CMAKE_CXX_STANDARD 17 #7

Closed
wants to merge 1 commit into from

Conversation

molafson
Copy link

@molafson molafson commented Aug 29, 2023

liboboe updated to use c++17.
This PR is to update the artifact hash so the artifact is built using C++17.

cd build_windows_32
cmake -G "Visual Studio 17 2022" -A Win32 -DCMAKE_CXX_STANDARD=17 ../
cmake --build . --config Release -j 2
cmake --build . --config Debug -j 2

cd build_windows_64
cmake -G "Visual Studio 17 2022" -A x64 -DCMAKE_CXX_STANDARD=17 ../
cmake --build . --config Release -j 2
cmake --build . --config Debug -j 2

NH-24785

@jerrytfleung jerrytfleung changed the title Updated gRPC with CMAKE_CXX_STANDARD 17 NH-24785 - Updated gRPC with CMAKE_CXX_STANDARD 17 Aug 29, 2023
Copy link

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @jerrytfleung!

@alehandru
Copy link

Default compiler and linker flags generated by gRPC's cmake can't be used to statically link with liboboe. As a result, they must be updated manually for all project files to match existing liboboe flags.

Building of gRPC library must be done using the Visual Studio solution and project files. The projects have been updated with compiler and linker flags required to statically link with liboboe.

To build with C++17 the following setting must be set to all gRPC project files (for all configurations 32/64 and Debug/Release): image

@molafson
Copy link
Author

Changes moved to PR: #8

@molafson molafson closed this Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants