Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

add Proxy configuration directive #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add Proxy configuration directive #19

wants to merge 1 commit into from

Conversation

hanshuebner
Copy link

This change adds a new proxy configuration directive to collectd-librato so that it can run on machines with no direct internet access. The proxy needs to be specified in : syntax:

   Proxy 10.1.1.1:3128

@nextmat
Copy link

nextmat commented Apr 9, 2014

Looks like this will attempt communications through both https and http access to the proxy? Wondering if scheme should be part of the config directive?

@mheffner
Copy link
Contributor

mheffner commented Apr 9, 2014

@nextmat Like this?

Proxy https://10.1.1.1:3128

@hanshuebner
Copy link
Author

As far as I understand, the protocol selector is used to choose a proxy according to the protocol of the URL that is being requested. For all practical purposes, this will be https, but maybe someone sets up a very convoluted setup, specifying a http url for the 'api' configuration and a proxy that only speaks https and an outgoing https translator.

In fact, it already seems possible to use the syntax that you've proposed, and urllib2 falls back to http if no protocol is specified in the proxy spec.

@nextmat
Copy link

nextmat commented Apr 10, 2014

@mheffner Yep, that was what I was asking.

@hanshuebner It has been my experience that orgs do strange things with proxies sometimes, often using an http or https connection to the proxy always regardless of the scheme of the outbound request. Just wanted to make sure this supports that case if we're adding proxy support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants