Support multiple peers for the "chat-with-mdns" example #2993
+162
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also update the example to use the latest version of go-libp2p? Update the |
|
@MqllR can you fix the merge conflict and the go check error: |
|
Merged master which fix the static check (see #3023). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chat-with-mdnsexample is pretty limited and quite confusing regarding the streams management. As a libp2p beginner, it is not easy to really get the behavior of theStreamHandlerand when another stream is opened.In addition, the input read from
Stdincannot be consumed from the different goroutines which make the example incompatible with a multi peers setup.In this PR, I propose to store the peers in a distinct struct to later be able to broadcast messages to all the peers part of the p2p network.
Execution example: