Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter nonroutable addrs #1003

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Filter nonroutable addrs #1003

wants to merge 1 commit into from

Conversation

gammazero
Copy link
Contributor

No description provided.

@guillaumemichel
Copy link
Contributor

See #839 and #872 for reference

@gammazero
Copy link
Contributor Author

@guillaumemichel Does you comment indicate that this PR is not needed, or that it should be using existing filtering code that is already in use by the PRs you referenced?

@guillaumemichel
Copy link
Contributor

Sorry I wasn't clear @gammazero!

My comment references the PRs in which a similar logic was implemented for the dht and dual packages. But this logic wasn't implemented for fullrt AFAICT. You can have a look at the PRs for inspiration or reuse some of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumemichel guillaumemichel Awaiting requested review from guillaumemichel guillaumemichel will be requested when the pull request is marked ready for review guillaumemichel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gammazero @guillaumemichel