Fixing recording move to memory #1306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
reviewed
Mar 27, 2024
| @@ -294,19 +295,21 @@ def _aslist(x): | |||
| return x | |||
|
|
|||
| # Case #1: no opts specified, read audio without decoding and move it in memory. | |||
| if all(opt is None for opt in (channels, offset, duration)) or ( | |||
| if format is None and (all(opt is None for opt in (channels, offset, duration)) or ( | |||
There was a problem hiding this comment.
if all(opt is None for opt in (channels, offset, duration, format)) would be clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move_to_memoryseems to fail for some cuts that have other audio soruce thanfile, no offset and duration matching the whole recording. I am fixing this for theurltype, but probably still fails with thecommandorsharsources.Also, I dont understand why there are
Case #1andCase #2in this method (I suppose case 1 is here to avoid additional decoding), especially when the user specifies a format that does not match the format of the original source. It looks like the case 1 condition should check also for the formats. 🤔 So feel free to fix it properly.