Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/resolving #10

Merged
merged 11 commits into from
Oct 28, 2023
Merged

Refactor/resolving #10

merged 11 commits into from
Oct 28, 2023

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented Oct 8, 2023 •
edited
Loading

This refactor reduces the gas fee of domain_to_address by avoiding recomputation of the domain hash. Needs to be reviewed after #9

@Th0rgal Th0rgal requested a review from irisdv October 8, 2023 08:45
irisdv
irisdv approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@irisdv irisdv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! but there is a conflict with the main branch

@Th0rgal Th0rgal self-assigned this Oct 12, 2023
@Th0rgal Th0rgal merged commit f354e42 into master Oct 28, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irisdv irisdv irisdv approved these changes

Assignees

@Th0rgal Th0rgal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Th0rgal @irisdv