SNMPv3 over DTLS #133

kdurkin77 · 2019-12-05T21:24:19Z

Updated to use DTLS2.Net to allow for SNMPv3 over DTLS. I updated DTLS.Net but since they haven't been responding to pull requests or issues I had use it from my fork and called it DTLS2.Net.

TSM doesn't use the Security Parameters part of the message, so set up SecurityParameters to have a default and Header, GetRequestMessage, and MessageFactory to not require them.

Added the SecurityModel enum to allow for either TSM or USM, keeping USM default. This required new constructors in GetRequestMessage to take in the SecurityModel

Test example:

var vList = new List<Variable>() { new Variable(new ObjectIdentifier("1.3.6.1.2.1.1.3.0")) };
var receiver = new IPEndPoint(ip, port);
var auth = TsmAuthenticationProvider.Instance;
IPrivacyProvider priv = new TsmPrivacyProvider(auth);

using var store = new X509Store(StoreName.My, StoreLocation.CurrentUser);
store.Open(OpenFlags.ReadOnly);
var myCertCollection = store.Certificates.Find(X509FindType.FindByThumbprint, "", true);

var chain = new X509Chain();
chain.Build(myCertCollection[0]);

var client = new Client(new IPEndPoint(IPAddress.Any, 0));
client.LoadX509Certificate(chain);
client.SupportedCipherSuites.Add(TCipherSuite.TLS_RSA_WITH_AES_256_CBC_SHA);

var request = new GetRequestMessage(VersionCode.V3, Messenger.NextMessageId, Messenger.NextRequestId, new OctetString(user), new OctetString(string.Empty), vList, priv, Messenger.MaxMessageSize);
var reply = request.GetSecureResponse(timeout, receiver, client);

foreach (var v in reply.Pdu().Variables)
{
	Console.WriteLine($"RESPONSE: {v}");
}

Pulling Changes

Update

TSM doesn't use the Security Parameters part of the message, so set up SecurityParameters to have a default and Header, GetRequestMessage, and MessageFactory to not require them. Added the SecurityModel enum to allow for either TSM or USM, keeping USM default. This required new constructors in GetRequestMessage to take in the SecurityModel Test example: var vList = new List<Variable>() { new Variable(new ObjectIdentifier("1.3.6.1.2.1.1.3.0")) }; var receiver = new IPEndPoint(ip, port); var auth = TsmAuthenticationProvider.Instance; IPrivacyProvider priv = new TsmPrivacyProvider(auth); using var store = new X509Store(StoreName.My, StoreLocation.CurrentUser); store.Open(OpenFlags.ReadOnly); var myCertCollection = store.Certificates.Find(X509FindType.FindByThumbprint, "", true); var chain = new X509Chain(); chain.Build(myCertCollection[0]); var client = new Client(new IPEndPoint(IPAddress.Any, 0)); client.LoadX509Certificate(chain); client.SupportedCipherSuites.Add(TCipherSuite.TLS_RSA_WITH_AES_256_CBC_SHA); var request = new GetRequestMessage(VersionCode.V3, Messenger.NextMessageId, Messenger.NextRequestId, new OctetString(user), new OctetString(string.Empty), vList, priv, Messenger.MaxMessageSize); var reply = request.GetSecureResponse(timeout, receiver, client); foreach (var v in reply.Pdu().Variables) { Console.WriteLine($"RESPONSE: {v}"); }

…perly - it uses C#7.0

lextm

Thanks for your effort. Several parts need modification, and if possible unit test cases should also be added.

SharpSnmpLib/SharpSnmpLib.csproj

lextm · 2019-12-05T22:26:53Z

SharpSnmpLib/SecurityParameters.cs

@@ -104,6 +104,15 @@ public OctetString AuthenticationParameters
        /// <value>The privacy parameters.</value>
        public OctetString PrivacyParameters { get; private set; }

+


Why do we need an empty constructor?

This isn't a constructor. I'm not sure if you selected the wrong part of the code or if there's a problem with PrivacyParameters here?

lextm · 2019-12-05T22:27:20Z

SharpSnmpLib/SecurityParameters.cs

@@ -178,6 +192,13 @@ public Sequence ToSequence()
        /// <returns></returns>
        public ISnmpData GetData(VersionCode version)
        {
+            //if empty SecurityParameters, return an empty OctetString


I will try to avoid such.

With TSM the security parameters have to be empty. Attached is a screen shot of the decrypted bytes to show that the security parameters are empty (an empty OctetString)

SharpSnmpLib/Security/DTLS/SecureListenerBinding.cs

SharpSnmpLib/Security/DTLS/MessageReceivedEventArgs.cs

SharpSnmpLib/Messaging/SecureListener.cs

SharpSnmpLib/Messaging/GetRequestMessage.cs

…arameters Put the namespaces back in order

…to Samples). Moved SecureMessageExtensions to SharpSnmpLib/Messaging and updated the namespace

…tRequestMessage

kdurkin77 · 2019-12-06T20:48:34Z

I believe I have updated everything you've asked for except for the 2 I've asked for clarification on. Please let me know if there's anything further, and thank you for getting back to me so quickly

kdurkin77 · 2019-12-10T16:35:02Z

Do you have a round about ETA on when this could be released?

lextm · 2019-12-10T18:43:34Z

Nope. No ETA at this moment. I am trying to set up a local lab environment to test out the changes, so it can take a relatively long period.

kdurkin77 · 2019-12-10T19:40:03Z

Understood, thank you!

…essage to allow for SNMPv3 TSM Removed the username parameter in GetRequestMessage setup for TSM

… types

…cting to a server through DTLS. Default is 1 second

Updated the DTLS2.Net library

Added targeting for netstandard2.1

lextm · 2020-01-15T02:34:41Z

SharpSnmpLib/Messaging/SecureDiscovery.cs

@@ -82,14 +82,14 @@ public SecureDiscovery(int messageId, int requestId, int maxMessageSize)
        /// <param name="responseTimeout">The time-out value, in milliseconds. The default value is 0, which indicates an infinite time-out period. Specifying -1 also indicates an infinite time-out period.</param>
        /// <param name="receiver">The receiver.</param>
        /// <returns></returns>
-        public ReportMessage GetResponse(int connectionTimeout, int responseTimeout, IPEndPoint receiver, Client client)
+        public async Task<ReportMessage> GetResponse(int connectionTimeout, int responseTimeout, IPEndPoint receiver, Client client)


Then you should rename it to GetResponseAsync.

Will update

lextm · 2020-01-15T02:35:09Z

SharpSnmpLib/Messaging/SecureMessageExtensions.cs


 namespace Lextm.SharpSnmpLib.Messaging
 {
    public static class SecureMessageExtensions
    {
-        public static ISnmpMessage GetSecureResponse(this ISnmpMessage request, int connectionTimeout, int responseTimeout, IPEndPoint receiver, Client client)
+        public static async Task<ISnmpMessage> GetSecureResponse(this ISnmpMessage request, int connectionTimeout, int responseTimeout, IPEndPoint receiver, Client client)


It should be changed to GetSecureResponseAsync.

Will update

…w a disposable

… load

Simplified platform check.

CLAassistant · 2020-04-27T20:24:22Z

All committers have signed the CLA.

Merging changes from master

…conds

…o LextudioMasterMerge

…lyzer.CSharp versions to match upstream master Few code feature updates in the DTLS specific stuff

kdurkin77 · 2024-05-29T18:40:30Z

Are there still plans to get this merged in at some point?

kdurkin77 added 7 commits November 15, 2019 12:23

Merge pull request #1 from lextudio/master

210a3be

Pulling Changes

Merge pull request #2 from lextudio/master

33d89e3

Update

Merge branch 'master' of https://github.com/kmiller77/sharpsnmplib

98a183d

Removed the project reference to DTLS2.Net and added the nuget package

ccb8536

Forgot to remove my test project

328f898

Removed the default keyword to allow for the Mac version to build pro…

900037d

…perly - it uses C#7.0

lextm requested changes Dec 5, 2019

View reviewed changes

lextm mentioned this pull request Dec 5, 2019

Implement DTLS support #73

Open

kdurkin77 added 3 commits December 6, 2019 11:16

Created a static Empty to use instead of the empty ctor for SecurityP…

7007b74

…arameters Put the namespaces back in order

Removed the Listeners and ListenerBindings (this needs to be moved in…

8319b80

…to Samples). Moved SecureMessageExtensions to SharpSnmpLib/Messaging and updated the namespace

Added some unit testing and removed incorrect parameter comment in Ge…

2b42aa7

…tRequestMessage

kdurkin77 mentioned this pull request Dec 6, 2019

DTLS addition lextudio/sharpsnmplib-samples#10

Open

lextm approved these changes Dec 6, 2019

View reviewed changes

kdurkin77 added 10 commits December 11, 2019 12:25

Updating DTLS2.Net Version

a11571a

Updated GetBulkRequestMessage, GetNextRequestMessage, and SetRequestM…

221da76

…essage to allow for SNMPv3 TSM Removed the username parameter in GetRequestMessage setup for TSM

Forgot to update the test - will add more tests for the other message…

817c5b2

… types

Updated DTLS2.Net package - that update includes a timeout when conne…

2c47b81

…cting to a server through DTLS. Default is 1 second

Added a timeout to connecting to the server in GetSecureResponse

1927f5a

Updated the DTLS2.Net library

Created separate timeout for connection and response

0d3b7a8

Updated to the new DTLS2.Net library

a7e33ce

Upgraded DTLS2.Net library - using async

a4488c8

Added targeting for netstandard2.1

Merge branch 'master' of https://github.com/lextudio/sharpsnmplib

c1e0a27

Fixed from merge

cb8914b

lextm reviewed Jan 15, 2020

View reviewed changes

kdurkin77 added 7 commits January 17, 2020 12:48

Updated DTLS2.Net project

14c6417

Updating DTLS2.Net and no longer calling StopAsync since Client is no…

44efc4c

…w a disposable

Updated the async functions to have the Async suffix

8dee6aa

Updating DTLS library

bff3913

Updated the DTLS2.Net library in an effort to help with high CPU with…

89f378c

… load

Merge pull request #6 from lextudio/master

39457b2

Simplified platform check.

Added support for standard 2.1 and upgraded DTLS2.Net

5adcd46

kdurkin77 and others added 7 commits June 11, 2020 09:43

Merge pull request #7 from lextudio/master

d27a0ec

Merging changes from master

Updated DTLS2.NET

fb4d8cf

Upgraded DLTS2.Net and added in missing .ConfigureAwait(false)

d849c60

Added ability to use TimeSpan for timeouts as well as int for millise…

18c2c72

…conds

Updated packages

59ce5d9

Updated DTLS2.Net

3d33735

Updated DTLS.Net library

b677193

lextm force-pushed the master branch 6 times, most recently from af8c507 to 83a3a43 Compare December 17, 2021 17:21

kdurkin77 added 2 commits February 16, 2022 14:27

Merge branch 'master' of https://github.com/lextudio/sharpsnmplib int…

4933bc7

…o LextudioMasterMerge

Some cleanup based on warnings

af04e83

lextm force-pushed the master branch from 01470e4 to 7d5599a Compare October 31, 2023 18:06

kdurkin77 added 4 commits May 10, 2024 12:37

merged from upstream master

c9cc316

corrected the target frameworks and added net8.0

dfed035

updated packages

a4c181d

Updated TargetFrameworks and Microsoft.SourceLink.GitHub and SonarAna…

2a55df2

…lyzer.CSharp versions to match upstream master Few code feature updates in the DTLS specific stuff

updated DTLS2.Net

ed31d91

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SNMPv3 over DTLS #133

SNMPv3 over DTLS #133

kdurkin77 commented Dec 5, 2019

lextm left a comment

lextm Dec 5, 2019

kdurkin77 Dec 6, 2019

lextm Dec 5, 2019

kdurkin77 Dec 6, 2019

kdurkin77 commented Dec 6, 2019

kdurkin77 commented Dec 10, 2019

lextm commented Dec 10, 2019

kdurkin77 commented Dec 10, 2019

lextm Jan 15, 2020

kdurkin77 Jan 28, 2020

lextm Jan 15, 2020

kdurkin77 Jan 28, 2020

CLAassistant commented Apr 27, 2020 •

edited

Loading

kdurkin77 commented May 29, 2024

		@@ -104,6 +104,15 @@ public OctetString AuthenticationParameters
		/// <value>The privacy parameters.</value>
		public OctetString PrivacyParameters { get; private set; }

SNMPv3 over DTLS #133

Are you sure you want to change the base?

SNMPv3 over DTLS #133

Conversation

kdurkin77 commented Dec 5, 2019

lextm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kdurkin77 commented Dec 6, 2019

kdurkin77 commented Dec 10, 2019

lextm commented Dec 10, 2019

kdurkin77 commented Dec 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Apr 27, 2020 • edited Loading

kdurkin77 commented May 29, 2024

CLAassistant commented Apr 27, 2020 •

edited

Loading