Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix removal of getWindowsOnWorkspace #67

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: fix removal of getWindowsOnWorkspace #67

merged 2 commits into from
Nov 25, 2024

Conversation

WhySoBad
Copy link
Collaborator

The getWindowsOnWorkspace method was removed so I changed all appearances to getWorkspaceById()->getWindows() which should be equivalent.

@WhySoBad WhySoBad marked this pull request as ready for review November 25, 2024 09:24
@WhySoBad WhySoBad self-assigned this Nov 25, 2024
@WhySoBad WhySoBad added bug Something isn't working and removed bug Something isn't working labels Nov 25, 2024
levnikmyskin
levnikmyskin approved these changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@levnikmyskin levnikmyskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@levnikmyskin levnikmyskin merged commit 86870aa into dev Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levnikmyskin levnikmyskin levnikmyskin approved these changes

Assignees

@WhySoBad WhySoBad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhySoBad @levnikmyskin