-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format workflow #66
base: dev
Are you sure you want to change the base?
Conversation
Thank you very much for taking the time for this. I was thinking: should we also use pre commit? I can take care of adding this over the weekend |
I don't fully understand what you mean by pre-commit. Do you mean to run the formatter in a git hook before committing or some kind of github workflow? |
Yes, a git hook. We can use https://pre-commit.com/ |
Yeah, sounds good. Do you mind adding it yourself? I don't know much about git hooks and probably won't find the time tomorrow to implement it |
Yeah will do it myself! Not in the next days probably, as I'm a little busy with personal stuff, but will try to not forget about this! |
hey @WhySoBad , finally added the pre-commit stuff. You can follow the instructions on https://pre-commit.com/ to install it. Also added a few other things. Let me know if this works for you! |
Hi, I think not having to rely on a 3rd party would be beneficial as it does not require every collaborator to first install another program just to install the script which runs the formatter. If we keep the current implementation I fear most people will simply not use it as the barrier for entry is too high. Edit: |
I get your point, fair concern. There was no particular reason other than I already use this at work, and it was really easy to setup. |
This pull request adds a github workflow which checks for correct code formatting.
I created a separate workflow file for the format check which is then run before the build job. This way it can be reused should there ever be another workflow which needs to run after the format check step.