Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed shared pointer reference #50

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

WhySoBad
Copy link
Collaborator

Using this fix the plugin works again for hyprland-git 0.41.1.r54.4a8b13ea-1

@WhySoBad WhySoBad requested a review from levnikmyskin June 22, 2024 09:46
@levnikmyskin
Copy link
Owner

Hi, code part looks good. I'll accept it and merge it once CI is fixed. If you can take care of that it'd be amazing, otherwise I'll commit to this branch (apparently hyprutils is missing from CI)

@WhySoBad
Copy link
Collaborator Author

WhySoBad commented Jun 24, 2024

I don't really understand the problem it's having. When I looked at your CI it seemed as if you were installing hyprutils?
But I'll give it a look later today :)

@WhySoBad
Copy link
Collaborator Author

@levnikmyskin I was able to fix the CI by installing hyprutils in the setup step :)

Copy link
Owner

@levnikmyskin levnikmyskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you as usual for your help :)

@levnikmyskin levnikmyskin merged commit fd9f63c into dev Jun 25, 2024
1 check passed
@levnikmyskin levnikmyskin deleted the remove-shared-pointer-reference branch June 25, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants