Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to link non-transfer transactions between each other by making them common_transfer #101

Merged
merged 20 commits into from
Jan 21, 2024
Merged

Ability to link non-transfer transactions between each other by making them common_transfer #101

merged 20 commits into from
Jan 21, 2024

Conversation

cripacrip
Copy link
Collaborator

No description provided.

@cripacrip cripacrip temporarily deployed to production October 4, 2023 10:21 — with GitHub Actions Inactive
@cripacrip cripacrip temporarily deployed to test October 4, 2023 10:22 — with GitHub Actions Inactive
letehaha
letehaha reviewed Oct 4, 2023
View reviewed changes
shared-types/routes/transactions.ts Outdated Show resolved Hide resolved
src/models/Transactions.model.ts Outdated Show resolved Hide resolved
@cripacrip cripacrip temporarily deployed to production October 11, 2023 18:39 — with GitHub Actions Inactive
@cripacrip cripacrip temporarily deployed to test October 11, 2023 18:40 — with GitHub Actions Inactive
letehaha
letehaha requested changes Oct 12, 2023
View reviewed changes
shared-types/routes/transactions.ts Outdated Show resolved Hide resolved
src/controllers/transactions.controller.ts Outdated Show resolved Hide resolved
src/controllers/transactions.controller.ts Outdated Show resolved Hide resolved
src/models/Transactions.model.ts Outdated Show resolved Hide resolved
src/services/transactions/get-transactions.ts Outdated Show resolved Hide resolved
@cripacrip cripacrip temporarily deployed to production October 14, 2023 08:08 — with GitHub Actions Inactive
@cripacrip cripacrip temporarily deployed to test October 14, 2023 08:09 — with GitHub Actions Inactive
letehaha
letehaha requested changes Oct 16, 2023
View reviewed changes
src/models/transactions.ts Outdated Show resolved Hide resolved
@cripacrip cripacrip temporarily deployed to production October 27, 2023 13:37 — with GitHub Actions Inactive
@cripacrip cripacrip temporarily deployed to production October 27, 2023 14:15 — with GitHub Actions Inactive
@cripacrip cripacrip temporarily deployed to production October 27, 2023 14:40 — with GitHub Actions Inactive
letehaha
letehaha requested changes Oct 30, 2023
View reviewed changes
Copy link
Owner

@letehaha letehaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to write e2e tests that prove that your implementation works correctly. There're various examples of tests for creation/updation flow.

shared-types/models/index.ts Outdated Show resolved Hide resolved
src/services/transactions/update-transaction.ts Outdated Show resolved Hide resolved
src/services/transactions/update-transaction.ts Outdated Show resolved Hide resolved
src/services/transactions/link-transaction.ts Outdated Show resolved Hide resolved
src/controllers/transactions.controller/create-transaction.ts Show resolved Hide resolved
@letehaha
Copy link
Owner

@cripacrip please resolve conflicts

@letehaha letehaha force-pushed the feat/link-transfer-transactions-btw-accounts branch from b08bb88 to a4c7cb1 Compare January 20, 2024 22:55
@letehaha letehaha self-requested a review January 21, 2024 20:36
@letehaha letehaha merged commit fcb35f9 into main Jan 21, 2024
4 checks passed
@letehaha letehaha deleted the feat/link-transfer-transactions-btw-accounts branch January 21, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letehaha letehaha letehaha approved these changes

Assignees

@cripacrip cripacrip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cripacrip @letehaha