chore: remove logging when running tests

letehaha · Sep 26, 2024 · b05226b · b05226b
1 parent 4357c03
commit b05226b
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 28 deletions.
diff --git a/src/js/utils/logger.ts b/src/js/utils/logger.ts
@@ -1,6 +1,12 @@
 import winston, { format, transports } from 'winston';
 
 const createWinstonLogger = () => {
+  if (process.env.NODE_ENV === 'test') {
+    return winston.createLogger({
+      silent: true,
+    });
+  }
+
   return winston.createLogger({
     level: 'info',
     format: format.combine(

diff --git a/src/redis.ts b/src/redis.ts
@@ -14,16 +14,15 @@ export const redisClient = createClient({
   },
 });
 
-console.time('connect-to-redis');
-redisClient
-  .connect()
-  .then(() => {
-    console.log('App connected to Redis! Took: ');
-    console.timeEnd('connect-to-redis');
-  })
-  .catch((err) => {
-    console.error('Cannot connect to Redis!', err);
-  });
+// console.time('connect-to-redis');
+redisClient.connect();
+// .then(() => {
+//   console.log('App connected to Redis! Took: ');
+//   console.timeEnd('connect-to-redis');
+// })
+// .catch((err) => {
+//   console.error('Cannot connect to Redis!', err);
+// });
 
 redisClient.on('error', (error: Error) => {
   logger.error({ message: 'Redis Client Error', error });

diff --git a/src/services/calculate-ref-amount.service.ts b/src/services/calculate-ref-amount.service.ts
@@ -75,9 +75,7 @@ async function calculateRefAmountImpl(params: Params): Promise<number> {
 
     return isNegative ? refAmount * -1 : refAmount;
   } catch (e) {
-    if (process.env.NODE_ENV !== 'test') {
-      logger.error(e);
-    }
+    logger.error(e);
     throw e;
   }
 }

diff --git a/src/services/transactions/create-transaction.ts b/src/services/transactions/create-transaction.ts
@@ -273,9 +273,7 @@ export const createTransaction = withTransaction(
 
       return transactions;
     } catch (e) {
-      if (process.env.NODE_ENV !== 'test') {
-        logger.error(e);
-      }
+      logger.error(e);
       throw e;
     }
   },

diff --git a/src/services/transactions/delete-transaction.ts b/src/services/transactions/delete-transaction.ts
@@ -81,9 +81,7 @@ export const deleteTransaction = withTransaction(async (params: Params): Promise
       ),
     );
   } catch (e) {
-    if (process.env.NODE_ENV !== 'test') {
-      logger.error(e);
-    }
+    logger.error(e);
     throw e;
   }
 });

diff --git a/src/services/transactions/transactions-linking/link-transactions.ts b/src/services/transactions/transactions-linking/link-transactions.ts
@@ -109,9 +109,7 @@ export const linkTransactions = withTransaction(
 
       return result;
     } catch (err) {
-      if (process.env.NODE_ENV !== 'test') {
-        logger.error(err);
-      }
+      logger.error(err);
       throw err;
     }
   },

diff --git a/src/services/tx-refunds/create-single-refund.service.ts b/src/services/tx-refunds/create-single-refund.service.ts
@@ -151,9 +151,7 @@ export const createSingleRefund = withTransaction(
 
       return refundTransaction;
     } catch (e) {
-      if (process.env.NODE_ENV !== 'test') {
-        logger.error(e);
-      }
+      logger.error(e);
       throw e;
     }
   },

diff --git a/src/services/tx-refunds/remove-refund-link.service.ts b/src/services/tx-refunds/remove-refund-link.service.ts
@@ -42,9 +42,7 @@ export const removeRefundLink = withTransaction(
         `Refund link between transactions ${originalTxId} and ${refundTxId} removed successfully`,
       );
     } catch (e) {
-      if (process.env.NODE_ENV !== 'test') {
-        logger.error('Error removing refund link:', e);
-      }
+      logger.error('Error removing refund link:', e);
       throw e;
     }
   },