fix: tx creation route validation

letehaha · Sep 17, 2024 · 69c05d7 · 69c05d7
1 parent 911c9bd
commit 69c05d7
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/src/controllers/transactions.controller/create-transaction.ts b/src/controllers/transactions.controller/create-transaction.ts
@@ -88,7 +88,7 @@ const bodyZodSchema = z
       .optional(),
     destinationAccountId: recordId().optional(),
     destinationTransactionId: recordId().optional(),
-    categoryId: recordId(),
+    categoryId: z.union([recordId(), z.undefined()]),
     transferNature: z.nativeEnum(TRANSACTION_TRANSFER_NATURE),
     refundsTxId: recordId().optional(),
   })
@@ -145,6 +145,21 @@ const bodyZodSchema = z
       message: `For ${TRANSACTION_TRANSFER_NATURE.common_transfer} without "destinationTransactionId" - "destinationAccountId", and "destinationAmount" must be provided`,
       path: ['destinationAccountId', 'destinationAmount', 'destinationTransactionId'],
     },
+  )
+  .refine(
+    (data) => {
+      if (
+        data.transferNature === TRANSACTION_TRANSFER_NATURE.not_transfer &&
+        data.categoryId === undefined
+      ) {
+        return false;
+      }
+      return true;
+    },
+    {
+      message: "'categoryId' is required for non-transfer transactions.",
+      path: ['categoryId', 'transferNature'],
+    },
   );
 
 export const createTransactionSchema = z.object({