Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Svg namespace #24

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Fix Svg namespace #24

merged 5 commits into from
Oct 29, 2020

Conversation

let-def
Copy link
Owner

@let-def let-def commented Oct 29, 2020

Fix issue #20. Better solutions might appear in the future on: ocsigen/tyxml#277.

Incidentally:

  • I removed Impure operator; I don't see any use for it yet
  • I augmented the primitive interface to give access to self instance

@let-def
Remove impure operator
3f4329a 
If necessary, it should not be difficult to re-implement.
On the other hand, I don't think Lwd code should rely on
initialization/evaluation order.  (or I have not yet found a compelling
case)
@let-def
tyxml: handle namespaces at creation
5cf2ae6
@let-def
Rework management of attributes, make all Svg elements live in svg na…
36867a6 
…mespace
@let-def
Lwd.prim: pass instance in acquire/release functions
7930869
@let-def
try to fix CI script
e927088
@let-def let-def merged commit 2986aa2 into master Oct 29, 2020
@let-def let-def deleted the tyxml-svg-xmlns branch October 29, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@let-def