Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shiftRowsUp/shiftRowsDown methods #127

Open
wants to merge 2 commits into
base: SNAPSHOT
Choose a base branch
from

Conversation

igorinov
Copy link

These row shifting functions were created for an experimental implementation of fixed lag smoother based on Kalman filter.
The shift functions were optimized out of that filter implementation later, but they may be useful for some other projects.

Copy link
Owner

@lessthanoptimal lessthanoptimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all looks good. One documentation comment. Could you remind me what the application is again?

}

/**
* Shifts all rows down by the specified number of places
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention what happens to the rows that are now unoccupied?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lessthanoptimal
Copy link
Owner

Could you also run ./gradlew spotlessApply it should fix the copyright issue and allow CI to pass. I think only one file should bechanged.

@igorinov
Copy link
Author

Over all looks good. One documentation comment. Could you remind me what the application is again?

It was added for fixed lag and fixed interval smoother. Recently I optimized my smoother implementation to avoid shifts, but they could be useful in other projects.

@lessthanoptimal
Copy link
Owner

CI still isn't passing. Did you try running ./gradlew spotlessApply yet?

@igorinov
Copy link
Author

igorinov commented Feb 1, 2021

FAILURE: Build failed with an exception.

* What went wrong:
Task 'spotlessApply' not found in root project 'ejml'.

@lessthanoptimal
Copy link
Owner

weird. Could you try this?

cd ejml
git fetch
git rebase origin/SNAPSHOT
./gradlew spotlessApply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants