-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shiftRowsUp/shiftRowsDown methods #127
base: SNAPSHOT
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all looks good. One documentation comment. Could you remind me what the application is again?
} | ||
|
||
/** | ||
* Shifts all rows down by the specified number of places |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mention what happens to the rows that are now unoccupied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Could you also run |
It was added for fixed lag and fixed interval smoother. Recently I optimized my smoother implementation to avoid shifts, but they could be useful in other projects. |
CI still isn't passing. Did you try running |
|
weird. Could you try this?
|
These row shifting functions were created for an experimental implementation of fixed lag smoother based on Kalman filter.
The shift functions were optimized out of that filter implementation later, but they may be useful for some other projects.