GitHub 上でカバレッジを確認できるようにする #72
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negokaz
commented
Oct 20, 2021
| @@ -1,5 +1,7 @@ | |||
| # lerna-app-library | |||
|
|
|||
| [](https://coveralls.io/github/lerna-stack/lerna-app-library?branch=main) | |||
|
|
|||
There was a problem hiding this comment.
結果を見る限り、命令網羅（C0）しか取得できていないように見える。
https://coveralls.io/github/lerna-stack/lerna-app-library
設定で、branch coverage の機能は有効化されている。
https://coveralls.io/github/lerna-stack/lerna-app-library/settings
There was a problem hiding this comment.
Coveralls の API ドキュメントを確認すると、coverage という（行ごとのカバレッジを表現する？）フィールドの他に branches という（分岐のカバレッジを表現する？）フィールドがある模様。coverage は必須のフィールドだが、branches はオプショナルなフィールドとして定義されている。
OBJECTS: SOURCE FILE
しかし、sbt-coveralls の実装を確認すると coverage フィールドしか設定されていないように見える。
gen.writeFieldName("coverage") gen.writeStartArray() report.lineCoverage.foreach { case Some(x) => gen.writeNumber(x) case _ => gen.writeNull() }sbt-coveralls/CoverallPayloadWriter.scala at v1.3.1 · scoverage/sbt-coveralls
There was a problem hiding this comment.
別のプロジェクトだが、分岐網羅のステータスが確認できているプロジェクトがあった。
sbt-coveralls が brances をサポートすると、lerna-app-library においても同様の表示ができるようになることが期待できる。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveralls.io/ というサービスを使う