Fix Broken Build on Node >= 12 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isopropylcyanide
changed the title
isopropylcyanide
changed the title
isopropylcyanide
changed the title
EfstathiadisD
suggested changes
Dec 10, 2020
Comment on lines
+40
to
+42
| "resolutions": { | ||
| "graceful-fs": "^4.2.4" | ||
| } |
There was a problem hiding this comment.
I see you already upgraded to Gulp version 4. From the Documentation, I see that resolutions are only needed if you want to work with Node > 12 and Gilp 3.x.x. Can you please try to remove it and see what happens?? Thanks for the PR.. 🚀
There was a problem hiding this comment.
Sure, thanks for pointing it out. The build works as expected. I've removed it.
There was a problem hiding this comment.
Thank you. Will merge it soon!! And sorry for the delay in getting back to you.
There was a problem hiding this comment.
Awesome, thanks a lot :)
EfstathiadisD
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken build on Node >= 12
Issue
Gulp@<4.0depends ongraceful-fs@^3.0.0. It monkeypatches Node.js fs module.