Yann/feature/imu/add event detection interrupt #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## yann/refactor/imu/standardize-naming #1405 +/- ##
========================================================================
- Coverage 98.76% 98.74% -0.02%
========================================================================
Files 146 146
Lines 3793 3822 +29
========================================================================
+ Hits 3746 3774 +28
- Misses 47 48 +1 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
a4b2b94
to
9b76514
Compare
YannLocatelli
changed the base branch from
develop
to
yann/refactor/imu/standardize-naming
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
4 times, most recently
from
4f22469
to
1efdbb9
Compare
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
2 times, most recently
from
70719bc
to
3522d75
Compare
1 task
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
e4473c7
to
d2a5eaf
Compare
|
YannLocatelli
force-pushed
the
yann/refactor/imu/standardize-naming
branch
from
7959b2d
to
0f38bca
Compare
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
d2a5eaf
to
a3ae74e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
YannLocatelli
force-pushed
the
yann/refactor/imu/standardize-naming
branch
from
0f38bca
to
d47f4db
Compare
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
a3ae74e
to
d2f09ee
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
YannLocatelli
force-pushed
the
yann/refactor/imu/standardize-naming
branch
from
d47f4db
to
9d2d183
Compare
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
be9b76e
to
eb0192b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
eb0192b
to
4405242
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ladislas
requested changes
Jul 24, 2024
Comment on lines
+140
to
+143
| void CoreIMU::registerOnWakeUpCallback(std::function<void()> const &callback) | ||
| { | ||
| _on_wake_up_callback = callback; | ||
| } |
There was a problem hiding this comment.
à mon sens le register il doit enable directement.
quel est le cas d'usage où on a besoin de faire les deux séparément ?
si on a un enable, je m'attends à avoir un disable aussi
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
5d683c6
to
1669492
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ladislas
requested changes
Aug 15, 2024
drivers/CoreIMU/source/CoreIMU.cpp
Outdated
| @@ -137,6 +137,52 @@ void CoreIMU::disableDeepSleep() | |||
| setPowerMode(interface::IMU::PowerMode::Normal); | |||
| } | |||
|
|
|||
| void CoreIMU::enableOnWakeUpInterrupt(std::function<void()> const &callback) | |||
There was a problem hiding this comment.
je suis pas trop fan du "enable interrupt + set a callback"
pour le DataReadyInterrupt, on enable ou disable tout simplement
ça serait mieux de faire ça là aussi et d'avoir un setWakeUpInterrupt
si on se projette un tout petit peu, on peut avoir le tap/double tap/freefall interrupts qui arrivent assez rapidement et il faut pouvoir les set et les enable/disable indépendamment et les avoir qui fonctionne en même temps.
il faut surement inverser un peu le fonctionnement et avoir le CoreIMU qui dit "y a eu un interrupt, voici son type" en utilisant un enum Interrupt avec dedans dataReady, wakeUp, etc.
on peut ensuite set les callbacks indépendamment pour chaque interrupt.
en interne on a un gros switch sur le interrupt type
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
1669492
to
4276867
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
YannLocatelli
force-pushed
the
yann/feature/imu/add-event-detection-interrupt
branch
from
4276867
to
89da6a4
Compare
ladislas
approved these changes
Aug 26, 2024
📈 Changes Impact Analysis Report📌 Info
🤖 Firmware impact analysis
Click to show memory sections🔬 Detailed impact analysisClick to show detailed analysis for all targets
🗺️ Map files diff output
|
🔖 Version comparison
|
|
📈 Changes Impact Analysis Report📌 Info
🤖 Firmware impact analysis
Click to show memory sections🔬 Detailed impact analysisClick to show detailed analysis for all targets
🗺️ Map files diff output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requis
Ressources
Registres concernés
Mise à jour du 19/07/2024
Le module LSM6DSOX embarque plusieurs reconnaissances de mouvement de base dont Wake-up et Activity, dont on peut les personnaliser que jusqu’à un certain point. Le schéma ci-dessous présente succintement quels sont les différents paramètres et les différentes reconnaissances disponibles.
On va utiliser la reconnaissance de mouvement de Activity, qui s’appuie sur la reconnaissance du mouvement Wake-up mais en plus travaillé. Les paramètres sont les suivants:
Filter and disable user offset
lsm6dsox_xl_hp_path_internal_set| SLOPE_FDS: HPF or SLOPE filter selection on wake-up and Activity/Inactivity functions. (Datasheet - 9.52)lsm6dsox_xl_usr_offset_on_wkup_set| USR_OFF_ON_WU: Drives the low-pass filtered data with user offset correction (instead of high-pass filtered data) to the wakeup function. (Datasheet - 9.57)Wakeup config
From AN5272 - 5.3
lsm6dsox_wkup_threshold_set| WK_THS: Threshold for wakeup. (Datasheet - 9.57)lsm6dsox_wkup_ths_weight_set| WAKE_THS_W: Weight of 1 LSB of wakeup threshold. (Datasheet - 9.58)lsm6dsox_wkup_dur_set| WAKE_DUR: Wake up duration event. (Datasheet - 9.58)Activity/Inactivity config
From AN5272 - 5.6
lsm6dsox_act_sleep_dur_set| SLEEP_DUR: Duration to go in sleep mode. (Datasheet - 9.58)lsm6dsox_act_mode_set| INACT_EN: Enable activity/inactivity (sleep) function. (Datasheet - 9.54)