Remove NSLogs for success cases

leits · Jun 27, 2023 · 4d4eb67 · 4d4eb67
1 parent 08614fe
commit 4d4eb67
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 34 deletions.
diff --git a/MeetingBar/AppDelegate.swift b/MeetingBar/AppDelegate.swift
@@ -206,7 +206,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
             if response.notification.request.content.categoryIdentifier == "EVENT" || response.notification.request.content.categoryIdentifier == "SNOOZE_EVENT" {
                 if let eventID = response.notification.request.content.userInfo["eventID"] as? String {
                     if let event = statusBarItem.events.first(where: { $0.ID == eventID }) {
-                        NSLog("Join \(event.title) event from notication")
                         event.openMeeting()
                     }
                 }
@@ -232,11 +231,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
         if response.notification.request.content.categoryIdentifier == "EVENT" || response.notification.request.content.categoryIdentifier == "SNOOZE_EVENT" {
             if let eventID = response.notification.request.content.userInfo["eventID"] as? String {
                 if let event = statusBarItem.events.first(where: { $0.ID == eventID }) {
-                    if action.durationInSeconds == 0 {
-                        NSLog("Snooze event until start")
-                    } else {
-                        NSLog("Snooze event for \(action.durationInMins) mins")
-                    }
                     snoozeEventNotification(event, action)
                 }
             }
@@ -250,7 +244,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
      */
 
     func openOnboardingWindow() {
-        NSLog("Open onboarding window")
         let contentView = OnboardingView()
         let onboardingWindow = NSWindow(
             contentRect: NSRect(x: 0, y: 0, width: 660, height: 450),
@@ -271,7 +264,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
 
     @objc
     func openChangelogWindow(_: NSStatusBarButton?) {
-        NSLog("Open changelof window")
         let contentView = ChangelogView()
         let changelogWindow = NSWindow(
             contentRect: NSRect(x: 0, y: 0, width: 600, height: 400),
@@ -294,7 +286,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
 
     @objc
     func openPrefecencesWindow(_: NSStatusBarButton?) {
-        NSLog("Open preferences window")
         let contentView = PreferencesView()
 
         if let preferencesWindow {
@@ -356,7 +347,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
 
     @objc
     func eventStoreChanged(_: NSNotification) {
-        NSLog("Store changed. Update status bar menu.")
         if statusBarItem == nil {
             return
         }
@@ -367,15 +357,13 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
 
     @objc
     private func fetchEvents() {
-        NSLog("Firing reccuring fetchEvents")
         DispatchQueue.main.async {
             self.statusBarItem.loadEvents()
         }
     }
 
     @objc
     private func updateStatusBarItem() {
-        NSLog("Firing reccuring updateStatusBarItem")
         DispatchQueue.main.async {
             self.statusBarItem.updateTitle()
             self.statusBarItem.updateMenu()
@@ -384,7 +372,6 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
 
     @objc
     func quit(_: NSStatusBarButton) {
-        NSLog("User click Quit")
         NSApplication.shared.terminate(self)
     }
 }
diff --git a/MeetingBar/EventStores/GCEventStore.swift b/MeetingBar/EventStores/GCEventStore.swift
@@ -104,7 +104,6 @@ class GCEventStore: NSObject, EventStore, OIDExternalUserAgent {
             if let url = URL(string: "https://www.googleapis.com/calendar/v3/calendars/\(calendar.ID)/events?singleEvents=true&orderBy=startTime&timeMax=\(timeMax)&timeMin=\(timeMin)") {
                 let service = GTMSessionFetcherService()
                 service.authorizer = auth
-                NSLog("Request GoogleAPI")
                 service.fetcher(with: url).beginFetch { data, error in
                     if error != nil {
                         if [OIDOAuthTokenErrorDomain, OIDHTTPErrorDomain].contains((error as NSError?)?.domain) {

diff --git a/MeetingBar/Extensions/URL.swift b/MeetingBar/Extensions/URL.swift
@@ -25,22 +25,18 @@ extension URL {
 
             NSWorkspace.shared.open([self], withApplicationAt: URL(fileURLWithPath: browserPath), configuration: configuration) { app, error in
                 guard app != nil else {
-                    NSLog("Can't open \(self) in \(browserName): \(String(describing: error?.localizedDescription))")
                     sendNotification("link_url_cant_open_title".loco(browserName), "link_url_cant_open_message".loco(browserName))
                     self.openInDefaultBrowser()
                     return
                 }
-                NSLog("Opening \(self) in \(browserName)")
             }
         }
     }
 
     @discardableResult
     func openInDefaultBrowser() -> Bool {
         let result = NSWorkspace.shared.open(self)
-        if result {
-            NSLog("Opening \(self) in default browser")
-        } else {
+        if !result {
             sendNotification("link_url_cant_open_title".loco("preferences_services_link_default_browser_value".loco()), "preferences_services_create_meeting_custom_url_placeholder".loco())
         }
         return result

diff --git a/MeetingBar/MeetingServices.swift b/MeetingBar/MeetingServices.swift
@@ -133,7 +133,6 @@ enum CreateMeetingServices: String, Codable, CaseIterable {
 }
 
 func createMeeting() {
-    NSLog("Create meeting in \(Defaults[.createMeetingService].rawValue)")
     let browser: Browser = Defaults[.browserForCreateMeeting]
 
     switch Defaults[.createMeetingService] {

diff --git a/MeetingBar/Notifications.swift b/MeetingBar/Notifications.swift
@@ -57,17 +57,12 @@ func registerNotificationCategories() {
 
     notificationCenter.setNotificationCategories([eventCategory, snoozeEventCategory])
 
-    notificationCenter.getNotificationCategories { categories in
-        for category in categories {
-            NSLog("Category \(category.identifier) was registered")
-        }
-    }
+    notificationCenter.getNotificationCategories { _ in }
 }
 
 func sendUserNotification(_ title: String, _ text: String, _ categoryIdentier: String? = nil) {
     requestNotificationAuthorization() // By the apple best practices
 
-    NSLog("Send notification: \(title) - \(text)")
     let center = UNUserNotificationCenter.current()
 
     let content = UNMutableNotificationContent()
@@ -134,8 +129,6 @@ func sendNotification(_ title: String, _ text: String) {
  * adds an alert for the user- we will only use NSAlert if the user has switched off notifications
  */
 func displayAlert(title: String, text: String) {
-    NSLog("Display alert: \(title) - \(text)")
-
     let userAlert = NSAlert()
     userAlert.messageText = title
     userAlert.informativeText = text

diff --git a/MeetingBar/Scripts.swift b/MeetingBar/Scripts.swift
@@ -56,8 +56,6 @@ func createAppleScriptParametersForEvent(event: MBEvent) -> NSAppleEventDescript
 
 // runs the predefined script with parameters.
 func runMeetingStartsScript(event: MBEvent, type: ScriptType) {
-    NSLog("Run apple script for event \(String(describing: event.ID))")
-
     let parameters = createAppleScriptParametersForEvent(event: event)
 
     let appleEvent = NSAppleEventDescriptor(

diff --git a/MeetingBar/StatusBarItemController.swift b/MeetingBar/StatusBarItemController.swift
@@ -830,10 +830,8 @@ class StatusBarItemController {
     @objc
     func joinNextMeeting() {
         if let nextEvent = getNextEvent(events: events) {
-            NSLog("Join next event")
             nextEvent.openMeeting()
         } else {
-            NSLog("No next event")
             sendNotification("next_meeting_empty_title".loco(), "next_meeting_empty_message".loco())
         }
     }
@@ -882,15 +880,13 @@ class StatusBarItemController {
 
     @objc
     func joinBookmark(sender: NSMenuItem) {
-        NSLog("Called to join bookmark")
         if let bookmark: Bookmark = sender.representedObject as? Bookmark {
             openMeetingURL(bookmark.service, bookmark.url, nil)
         }
     }
 
     @objc
     func clickOnEvent(sender: NSMenuItem) {
-        NSLog("Click on event (\(sender.title))!")
         if let event: MBEvent = sender.representedObject as? MBEvent {
             event.openMeeting()
         }