Fix #122: Add FAN expansion mode #126
Conversation
Change FabWithLabelView to ConstraintLayout. - This allows both horizontal and vertical expansion modes to show labels Set layout params for each menu item to mimic expansion mode for top/bottom/left and right Expose hiding of label from FabWithLabelView - For FAN expansion mode, the text is displayed below mini fab - for right or left expansion modes, the text is always disabled. Same as existing behaviour Format code according to code style Update sample app to show FAN expansion mode
kiewietn
force-pushed
the
fan-expansion-mode
branch
from
1b956ce to
dee3634
Compare
|
Not really sure how to handle the overlapping text. |
There was a problem hiding this comment.
Hi @kiewietn, thanks a lot for the Pull Request, but I'm afraid I will not be able to accept it until the issue with the overlapping/cut labels is solved: I'm absolutely positive that, if the current implementation will be released, I would get many bug reports for this problem.
|
@leinardi, thanks for the comment. To mitigate risk of overlapping labels, the maximum number of characters displayed on the label could be limited when using the FAN expansion mode. The label length restrictions applied to the other expansion modes remain unchanged.
Please let me know if this is satisfactory. |
|
Hi @kiewietn, sorry for the late reply, busy week at work. This is definitely an improvement but I'm still afraid that people will not understand this limitation and will keep opening issues complaining for the cut labels. I would be fine to release this feature as experimental but I'm not sure how to do it with Java. I also notice a bug with the action items alignment: It seems that, on your fork, they are not aligned to the main FAB anymore: Upstream master doesn't have the issue: |
affect of long labels overlapping.
|
Thanks for coming back to me @leinardi .
|
|
This issue has been automatically marked as stale because it has not had activity in the last 60 days. |
|
This issue has been automatically marked as stale because it has not had activity in the last 60 days. |
First time contributor checklist
Contributor checklist
using the
Fixes #1234syntaxDescription
Add an expansion mode, where the items are arranged radially around the main FAB.
Items with label text set, will have the labels display below the mini fab item.
The radius length of the expansion mode can be changed from the xml layout file using the
layout_constraintCircleRadius.