rfcbot: update to recognise expanded template name #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify template-finding regex to also match expanded versions of the {{rfc}} template, in preparation for the planned move of the template to {{request for comment}} (https://w.wiki/Ak3j).
- in order to bridge the gap between the old and the new template names, modify the code that gets a list of pages transcluding {{rfc}} to also get a list of pages transcluding {{request for comment}} (before then merging the two lists together).
- also changed some `str_replace` calls in the syntax-fixing code to use `str_ireplace`, to fix a potential edge case where a capital letter at the start of an {{RFC}} tag could prevent the bot from successfully fixing its syntax.
hopefully this won’t break anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
str_replacecalls in the syntax-fixing code to usestr_ireplace, to fix a potential edge case where a capital letter at the start of an {{RFC}} tag could prevent the bot from successfully fixing its syntax.hopefully this won’t break anything
With respect to #13 (comment), I don’t see that the template being renamed means that the bot necessarily has to output the expanded version of the title — {{rfc}} will still redirect to {{request for comment}}, and so will work as normal as a template shortcut. As I see it, the main benefit here would be the actual template name being expanded for clarity - imo, there wouldn't be an issue with Legobot continuing to output {{rfc}}.
I also added support for the version without spaces ({{requestforcomment}}); which is currently marked as being deprecated, but which could be re-redirected to the main template if this PR gets merged.