Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global pdfjsImagePath #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Paulsky
Copy link

@Paulsky Paulsky commented May 26, 2017

  • Changed '@pdfjsImagePath' to '@{pdfjsImagePath}' in build.sh.

Please see my pull request in the pdf.js repository for setting the correct paths. By setting the correct paths in viewer.css in the pdf.js repository, the global 'pdfjsImagePath' variable can be set by using the following commands:

  • lessc command:
    lessc viewer.less viewer.css --global-var="pdfjsImagePath=path/to/images"

  • gulpfile (for example Laravel elixir):
    globalVars: {
    pdfjsImagePath: "'path/to/images'"
    }

- Changed "url(@pdfjsImagePath/*.*)" to "url('@{pdfjsImagePath}/*.*')"
- Changed CSS class 'pdfjs 0%' to 'pdf0'
- Changed CSS class 'pdfjs 100%' to 'pdf100'
- Added '/.idea' to .gitignore for PHPStorm project.

usages for setting the var:
- lessc command:
   lessc viewer.less viewer.css --global-var="pdfjsImagePath=path/to/images"

- gulpfile (for example laravel elixir):
    globalVars: {
        pdfjsImagePath: "'path/to/images'"
    }
@svenstm svenstm requested a review from jasny April 17, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant