fix: close ledger sheet in request keys flow #6024
Conversation
|
|
||
| return ( | ||
| <LedgerRequestKeysProvider value={context}> | ||
| <Sheet | ||
| isShowing | ||
| header={<SheetHeader />} | ||
| onClose={isActionCancellableByUser ? onCancelConnectLedger : undefined} | ||
| onClose={isActionCancellableByUser ? () => navigate(RouteUrls.Home) : undefined} |
There was a problem hiding this comment.
This seems OK but we have another method in ledgerNavigate called cancelLedgerActionAndReturnHome, maybe we can use that?
It seems like for some reason the code in cancelLedgerAction doesn't catch the route you are on (maybe as it's a nested route) so you could also try and fix that to handle nested routes
|
The routes for the ledger flows are such that |
alter-eggo
force-pushed
the
fix/go-back-ledger-request
branch
from
ed39244 to
3992286
Compare
| const baseUrl = `/${location.pathname.split('/')[1]}`; | ||
|
|
||
| return navigate(baseUrl, { | ||
| return navigate('..', { |
There was a problem hiding this comment.
Did you track back to the PR where I changed it? I think changing it back to '..' will re-introduce this bug.
If you're confident this will work fair enough. I think the problem you hit is a new bug and could be solved by making the baseUrl find the route you are on more accurately
Fixed broken close ledger connect sheet