Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create rpc method to link to swap/bridge #6004

Closed
wants to merge 2 commits into from

Conversation

camerow
Copy link
Collaborator

@camerow camerow commented Dec 11, 2024

Try out Leather build ca5b30cExtension build, Test report, Storybook, Chromatic

@fbwoolf
Copy link
Contributor

fbwoolf commented Dec 12, 2024

I know @pete-watters implemented the rpcOpen with the intention (I think) of allowing a specific route in the wallet to be opened? It was implemented initially to just open the home route, but maybe we can just expand that one?

@@ -22,6 +23,10 @@ export async function rpcMessageHandler(message: WalletRequests, port: chrome.ru
await rpcOpen(message, port);
break;
}
case 'swap': {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would call it this message something less terse, to indicate that this isn't our API to initiate/track a swap, rather, just opening that page.

@pete-watters
Copy link
Contributor

I know @pete-watters implemented the rpcOpen with the intention (I think) of allowing a specific route in the wallet to be opened? It was implemented initially to just open the home route, but maybe we can just expand that one?

👍 maybe we can do that. We had a follow on task to extend rpcOpen here with some more implementation requests.

@kyranjamie
Copy link
Collaborator

Is the intention of this to be only for use with Leather? If so I'd suggest we prefix the method with something like leather_*

@camerow camerow closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants