Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove un-needed p-queue package, ref LEA-1500 #5908

Merged
merged 1 commit into from
Oct 16, 2024
Merged

chore: remove un-needed p-queue package, ref LEA-1500 #5908

merged 1 commit into from
Oct 16, 2024

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Oct 16, 2024 •
edited by leather-bot
Loading

Try out Leather build e60a7cc — Extension build, Test report, Storybook, Chromatic

Working on LEA-1500 and I hit an issue with p-queue having problems with options.signal.throwIfAborted when calling queries in React Native.

Digging into it and considering a downgrade in the query package helped me discover we don't need this in the extension at all

@linear Linear
Copy link

linear bot commented Oct 16, 2024

LEA-1500 Fetch Stacks data on mobile

@pete-watters pete-watters marked this pull request as ready for review October 16, 2024 09:46
@pete-watters pete-watters added this pull request to the merge queue Oct 16, 2024
Merged via the queue into dev with commit 1df5138 Oct 16, 2024
31 checks passed
@pete-watters pete-watters deleted the chore/LEA-1500/fetch-stacks-data branch October 16, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

@alter-eggo alter-eggo Awaiting requested review from alter-eggo

@alexp3y alexp3y Awaiting requested review from alexp3y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pete-watters @kyranjamie