-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle metadata inheritance for non uploaded nodes in edit modal #4769
Properly handle metadata inheritance for non uploaded nodes in edit modal #4769
Conversation
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Show resolved
Hide resolved
...ration/contentcuration/frontend/channelEdit/components/edit/InheritAncestorMetadataModal.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes makes sense to me! And active logic now looks easier to understand. I just found one little bug on the first file upload after we had applied the "dont ask me again" option.
Compartir.pantalla.-.2024-09-27.16_04_00.mp4
… files. Use this to conditionalize explicit triggering of inheritance check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rtibbles! Code changes looks good to me, and I havent found anything wrong on Manual QA. LGTM!
I think you mean:
:D |
LGTM as well! |
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Fixes #4762
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)