Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle metadata inheritance for non uploaded nodes in edit modal #4769

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Sep 27, 2024

Summary

Description of the change(s) you made

  • Use selected for node ids for inheritance when not uploading
  • Ensure that we properly retrigger the inheritance modal checks when something new is added in the same edit modal lifecycle

Manual verification steps performed

  1. Create a new folder, ensure that the modal triggers and applies
  2. Within the same edit modal session click "add new folder" and ensure the same behaviour happens
  3. Repeat with "don't show this again" behaviour
  4. Create a new exercise, ensure that the modal triggers and applies
  5. Repeat with "Don't show this again" behaviour

Screenshots (if applicable)

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

Fixes #4762

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes makes sense to me! And active logic now looks easier to understand. I just found one little bug on the first file upload after we had applied the "dont ask me again" option.

Compartir.pantalla.-.2024-09-27.16_04_00.mp4

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rtibbles! Code changes looks good to me, and I havent found anything wrong on Manual QA. LGTM!

@rtibbles
Copy link
Member Author

I havent found anything wrong on Manual QA

I think you mean:

I havent found anything else wrong on Manual QA

:D

@rtibbles rtibbles merged commit 73cbda7 into learningequality:unstable Sep 27, 2024
13 checks passed
@rtibbles rtibbles deleted the folders_and_exercises branch September 27, 2024 22:17
@pcenov
Copy link
Member

pcenov commented Sep 30, 2024

LGTM as well!

This was referenced Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Inheritable modal - No metadata is added to a newly created folder or exercise
3 participants