Inheritance modal release blocking fixes

[rtibbles]

Summary

Description of the change(s) you made

• Fixes saving of preferences by properly checking for the existence of falsy values.
• Defer setting metadata onto nodes in file upload until after all nodes have been created from file uploads
• On cancel of the inheritance modal, emit an empty inherit payload to ensure that consumers clear inheriting nodes etc. appropriately

Manual verification steps performed

See issues below for reproduction steps.

References

Fixes #4752
Fixes #4753
Fixes #4755

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[akolson]

HI @rtibbles! Changes make sense to me. However, I am still able to replicate #4755. The rest have been fixed.

Screen.Recording.2024-09-26.at.14.39.57.mov

[rtibbles]

Looks like I wasn't properly emitting the inherit event that was intended to fix this final issue - I guess whatever error that was triggering was making it looked like it worked locally! Should be fixed now.

[akolson]

Thanks @rtibbles. Both code changes and manual QA check out. Good to go!

[pcenov]

Hi @rtibbles - I confirm that the above mentioned 3 issues are fixed. Have reported the following follow-up issue: #4762