Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes frontend to properly call invitation accept endpoint. #4673

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

Fixes oversight from #4615 where the frontend was not properly updated to use the new invitation accept API endpoint for synchronous acceptance of channel invitations

Manual verification steps performed

  1. Invite another user to a channel
  2. Accept that invitation as the other user
  3. Rejoice!

References

Fixes #4643

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - changes from patch which was causing an error, and manual QA test confirms that i was able to accept the invitation and open the channel

@marcellamaki marcellamaki merged commit 66f955c into learningequality:unstable Aug 27, 2024
13 checks passed
@marcellamaki marcellamaki mentioned this pull request Aug 27, 2024
@radinamatic
Copy link
Member

I was also able to accept the invitation and open the channel, but the invitation remained sticky on the top of My channels page even after clicking the ✔️ button several times, navigating away and back, and even after signing out and in again... I eventually had to decline the invitation (that I previously accepted!), in order to make it go away finally 🤷🏽

@akolson
Copy link
Member

akolson commented Aug 28, 2024

cc @rtibbles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Cannot accept channel editing/viewing invitation
4 participants