Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken 'Go to location' link in Import Search #4175

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

bjester
Copy link
Member

@bjester bjester commented Jun 23, 2023

Summary

Description of the change(s) you made

  • Adds parent when converting from public node format to Studio's IDs

Manual verification steps performed

  1. Create a channel
  2. Add a topic and put content in the topic
  3. Make the channel public
  4. Publish the channel
  5. Create a second channel
  6. Use the import search to search for resources added to the topic in the first channel
  7. Preview resources from search
  8. Click the 'Go to location' and ensure it opens the correct topic and resource panel preview

Does this introduce any tech-debt items?

It appears the search results are rendering in an order that is different than what is returned from the server.

References

Fixes: #4168

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - seems to fix in the UI. I'm not sure if the order should be considered a blocking change here, and whether or not that is connected to this specific fix. If that can be resolved separately, I think this is okay to merge

@@ -43,7 +43,6 @@ const CONTENT_NODE_FIELD_MAP = {
node_id: 'id',
content_id: 'content_id',
channel_id: 'channel_id',
parent: 'parent',
Copy link
Member

@marcellamaki marcellamaki Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this deleted here? this is a curious question not an implication that "it shouldn't be" :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By removing this from the map, it prevents the parent from being overwritten in convertContentNodeResponse, because it's now manually being set.

@bjester bjester merged commit 3084d31 into learningequality:hotfixes Jun 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants