Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contains Content From in the CSV export for a Channel #4043

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

manavagr1108
Copy link
Contributor

@manavagr1108 manavagr1108 commented Apr 29, 2023

Summary

Description of the change(s) you made

Solves #3198

Manual verification steps performed

  1. Tested on local setup

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@@ -125,6 +127,7 @@ export const channelExportMixin = {
channel.aggregators,
channel.licenses,
channel.copyright_holders,
channel.containsContentFrom,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, when I tested this locally, the contains content from field was present in the CSV, but empty.

I think containsContentFrom may not be the correct key to get this information.

In the Details modal, it references original_channels for this information: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/frontend/shared/views/details/Details.vue#L251

But we may want to limit that to just the titles of those channels.

To test this, there should be an 'imported channel' in the default test setup, it should show the 'Published Channel' in this column for its CSV export.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too faced the same issue, that the field was empty. I did try to test it properly but not sure why I couldn't import channels in my locally that were published already. I also tried various ways by creating new published channels, and all that did not work. I will try to fix this by this weekend, haven't been able to give a look at it cos of the final lab-exams and end exams. I will try to fix this by this weekend. Sorry for the delay.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem - we understand you are busy and volunteering your time!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rtibbles !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants