Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(AlgebraicGeometry/Pullback): description of the underlying topological space of a fiber product of schemes #17767

Closed
wants to merge 22 commits into from

Conversation

chrisflav
Copy link
Collaborator

@chrisflav chrisflav commented Oct 15, 2024

Let f : X ⟶ S and g : Y ⟶ S be morphisms of schemes. In this PR we describe the underlying
topological space of pullback f g, i.e. the fiber product X ×[S] Y. In particular, we show that the points of X ×[S] Y correspond bijectively to pairs (z, p) of triples z = (x, y, s) with f x = s = g y and prime ideals q of κ(x) ⊗[κ(s)] κ(y).

From the valuative criterion project.

Co-authored-by: Qi Ge
Co-authored-by: Andrew Yang


Open in Gitpod

@chrisflav chrisflav added the t-algebraic-geometry Algebraic geometry label Oct 15, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

PR summary 2205925ca6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.PullbackCarrier 1858

Declarations diff

+ SpecOfPoint
+ SpecTensorTo
+ SpecTensorTo_SpecOfPoint
+ Spec_map_tensorInl_fromSpecResidueField
+ Spec_map_tensor_isPullback
+ Triplet
+ Triplet.Spec_ofPointTensor_SpecTensorTo
+ Triplet.exists_preimage
+ carrierEquiv
+ carrierEquiv_eq_iff
+ carrierEquiv_symm_fst
+ carrierEquiv_symm_snd
+ exists_preimage_pullback
+ ext
+ instance (T : Triplet f g) : Nontrivial T.tensor
+ mk'
+ ofPoint
+ ofPointTensor
+ ofPointTensor_SpecTensorTo
+ ofPoint_SpecTensorTo
+ range_fst
+ range_fst_comp
+ range_map
+ range_snd
+ range_snd_comp
+ residueFieldCongr_inv_residueFieldMap_ofPoint
+ specTensorTo_base_fst
+ specTensorTo_base_snd
+ specTensorTo_fst
+ specTensorTo_snd
+ tensor
+ tensorCongr
+ tensorCongr_SpecTensorTo
+ tensorCongr_inv
+ tensorCongr_refl
+ tensorCongr_symm
+ tensorCongr_trans
+ tensorCongr_trans_hom
+ tensorInl
+ tensorInr

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 15, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 16, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 19, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Oct 20, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 20, 2024
Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I also contributed a significant portion of this.

Mathlib/Algebra/Category/Ring/Constructions.lean Outdated Show resolved Hide resolved
Mathlib/AlgebraicGeometry/PullbackCarrier.lean Outdated Show resolved Hide resolved
Mathlib/AlgebraicGeometry/PullbackCarrier.lean Outdated Show resolved Hide resolved
Mathlib/AlgebraicGeometry/PullbackCarrier.lean Outdated Show resolved Hide resolved
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 21, 2024
@chrisflav chrisflav removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 22, 2024
Copy link
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 23, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 23, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 26, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 4, 2024
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 4, 2024
@kim-em
Copy link
Contributor

kim-em commented Nov 4, 2024

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 4, 2024

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@chrisflav
Copy link
Collaborator Author

Thanks for the reviews!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 5, 2024
…ogical space of a fiber product of schemes (#17767)

Let `f : X ⟶ S` and `g : Y ⟶ S` be morphisms of schemes. In this PR we describe the underlying
topological space of `pullback f g`, i.e. the fiber product `X ×[S] Y`. In particular, we show that the points of `X ×[S] Y` correspond bijectively to pairs `(z, p)` of triples `z = (x, y, s)` with `f x = s = g y` and prime ideals `q` of `κ(x) ⊗[κ(s)] κ(y)`.

From the valuative criterion project.

Co-authored-by: Qi Ge
Co-authored-by: Andrew Yang



Co-authored-by: Andrew Yang <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry/Pullback): description of the underlying topological space of a fiber product of schemes [Merged by Bors] - feat(AlgebraicGeometry/Pullback): description of the underlying topological space of a fiber product of schemes Nov 5, 2024
@mathlib-bors mathlib-bors bot closed this Nov 5, 2024
@mathlib-bors mathlib-bors bot deleted the chrisflav-pullback-carrier branch November 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants