Add typescript 4.3 support #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konowrockis
force-pushed
the
feature/routes-2.0
branch
2 times, most recently
from
8962691 to
0df3006
Compare
kartonixon
approved these changes
Jun 22, 2021
konowrockis
force-pushed
the
feature/routes-2.0
branch
2 times, most recently
from
99fa3f6 to
8feb706
Compare
kotertom
reviewed
Jul 5, 2021
kotertom
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this pull request is to update TypeScript to 4.3 because ts-routes 1.0 is not compatible with TS > 4.0.
Side effect of that is that it addresses #2 and #9.
I migrated underlying implementation of query strings parsing and stringifying to
qsbecausequery-stringdoes not support objects serialization. Also added benefit is that I've exposed configration forqs.The types has simplified a bit and also I think it'll be easier to add new features in the future.