Bump min sdk to 3.5.0 in all packages (#2371)

* Bump min sdk to 3.5.0 across packages * Add check-semver workflow for patrol_finders * Bump Flutter and Dart version in workflows * Adjust to new linter rules in patrol_finders package * Adjust to new linter rules in patrol_cli package * Fix analyzer issues in package adb * Adjust to new linter rules in patrol package * Replace deprecated onPopInvoked parameter * Use Flutter 3.24 in patrol develop tests * Bump leancode_lint to 14.2.0 * Bump dependecies * Fix patrol_cli tests --------- Co-authored-by: piotruela <[email protected]>
leancodepl · Oct 17, 2024 · 9f04057 · 9f04057
1 parent dd3368e
commit 9f04057
Show file tree

Hide file tree

Showing 51 changed files with 396 additions and 253 deletions.
diff --git a/.cirrus.yml b/.cirrus.yml
@@ -9,7 +9,7 @@ test_linux_task:
     kvm: "true"
   env:
     PATH: $HOME/.pub-cache/bin:$HOME/fvm/default/bin:$CIRRUS_WORKING_DIR/fvm:${PATH}
-    FLUTTER_VERSION: "3.22.0"
+    FLUTTER_VERSION: "3.24.0"
     EMULATOR_API_LEVEL: "34"
     EMULATOR_ABI: google_apis_playstore;x86_64
     EMULATOR_IMAGE: system-images;android-${EMULATOR_API_LEVEL};${EMULATOR_ABI}
@@ -66,7 +66,7 @@ test_macos_task:
     image: ghcr.io/cirruslabs/macos-sonoma-xcode:latest
   env:
     PATH: $HOME/.pub-cache/bin:$HOME/fvm/default/bin:${PATH}
-    FLUTTER_VERSION: "3.22.0"
+    FLUTTER_VERSION: "3.24.0"
   timeout_in: 30m
 
   set_up_fvm_script: |

diff --git a/.github/workflows/adb-prepare.yaml b/.github/workflows/adb-prepare.yaml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        dart-version: ['3.3']
+        dart-version: ['3.5']
 
     defaults:
       run:

diff --git a/.github/workflows/check-semver.yaml → .github/workflows/patrol-check-semver.yaml b/.github/workflows/check-semver.yaml → .github/workflows/patrol-check-semver.yaml
@@ -1,4 +1,4 @@
-name: check semver
+name: patrol check semver
 
 on:
   workflow_dispatch:
@@ -37,7 +37,7 @@ jobs:
             channel: ${{ matrix.flutter-channel }}
 
         - name: Install dart-apitool
-          run: dart pub global activate dart_apitool
+          run: dart pub global activate dart_apitool 0.19.0
 
         - name: Check API changes
           run: |

diff --git a/.github/workflows/patrol-prepare.yaml b/.github/workflows/patrol-prepare.yaml
@@ -15,7 +15,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [windows-latest]
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:
@@ -65,7 +65,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:
@@ -133,7 +133,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-13]
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:
@@ -173,7 +173,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:

diff --git a/.github/workflows/patrol-publish.yaml b/.github/workflows/patrol-publish.yaml
@@ -20,7 +20,7 @@ jobs:
 
     strategy:
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     steps:

diff --git a/.github/workflows/patrol_cli-prepare.yaml b/.github/workflows/patrol_cli-prepare.yaml
@@ -15,7 +15,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest]
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:

diff --git a/.github/workflows/patrol_devtools_extension-prepare.yaml b/.github/workflows/patrol_devtools_extension-prepare.yaml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:

diff --git a/.github/workflows/patrol_finders-check-semver.yaml b/.github/workflows/patrol_finders-check-semver.yaml
@@ -0,0 +1,46 @@
+name: patrol_finders check semver
+
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - 'packages/patrol_finders/**'
+
+jobs:
+  check_semver:
+    name: Check semver
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        flutter-version: ['3.24.x']
+        flutter-channel: ['stable']
+
+    steps:
+        - name: Clone repository
+          uses: actions/checkout@v4
+          with:
+            fetch-depth: 0
+
+        - name: Get last released version
+          id: get_last_released_version
+          run: |
+            last_version=$(git tag --list 'patrol_finders-v*' | grep -v '\-dev\.[0-9]\+$' | sort -V | tail -n 1 | sed 's/^patrol_finders-v//')
+            echo "last_version=$last_version" >> $GITHUB_ENV
+            echo "::set-output name=last_version::$last_version"
+
+        - name: Set up Flutter
+          uses: subosito/flutter-action@v2
+          with:
+            flutter-version: ${{ matrix.flutter-version }}
+            channel: ${{ matrix.flutter-channel }}
+
+        - name: Install dart-apitool
+          run: dart pub global activate dart_apitool 0.19.0
+
+        - name: Check API changes
+          run: |
+            dart-apitool diff \
+            --old pub://patrol_finders/${{ steps.get_last_released_version.outputs.last_version }} \
+            --new packages/patrol_finders
diff --git a/.github/workflows/patrol_finders-prepare.yaml b/.github/workflows/patrol_finders-prepare.yaml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:

diff --git a/.github/workflows/patrol_finders-publish.yaml b/.github/workflows/patrol_finders-publish.yaml
@@ -20,7 +20,7 @@ jobs:
 
     strategy:
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     steps:

diff --git a/.github/workflows/patrol_gen-prepare.yaml b/.github/workflows/patrol_gen-prepare.yaml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        dart-version: ['3.3']
+        dart-version: ['3.5']
 
     defaults:
       run:

diff --git a/.github/workflows/prepare-e2e_app.yaml b/.github/workflows/prepare-e2e_app.yaml
@@ -17,7 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [windows-latest]
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:
@@ -66,7 +66,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:
@@ -121,7 +121,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-13]
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:
@@ -193,7 +193,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
 
     defaults:

diff --git a/.github/workflows/test-android-device.yaml b/.github/workflows/test-android-device.yaml
@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
         os: ['Android API']
         include:

diff --git a/.github/workflows/test-ios-device.yaml b/.github/workflows/test-ios-device.yaml
@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
         device_model: ['iphone14pro']
         os_version: ['16.6']

diff --git a/.github/workflows/test-ios-simulator-webview.yaml b/.github/workflows/test-ios-simulator-webview.yaml
@@ -23,7 +23,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ["3.22.x"]
+        flutter-version: ["3.24.x"]
         flutter-channel: ["stable"]
         device_model: [iPhone 14]
         os: [iOS]

diff --git a/.github/workflows/test-ios-simulator.yaml b/.github/workflows/test-ios-simulator.yaml
@@ -24,7 +24,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ["3.22.x"]
+        flutter-version: ["3.24.x"]
         flutter-channel: ["stable"]
         device_model:
           [iPhone SE (3rd generation), iPhone 14, iPad (10th generation)]

diff --git a/.github/workflows/test-macos.yaml b/.github/workflows/test-macos.yaml
@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        flutter-version: ['3.22.x']
+        flutter-version: ['3.24.x']
         flutter-channel: ['stable']
         device_model: [macOS]
         os: [macOS]

diff --git a/dev/cli_tests/pubspec.yaml b/dev/cli_tests/pubspec.yaml
@@ -2,10 +2,10 @@ name: cli_tests
 description: Scripts to test patrol_cli.
 
 environment:
-  sdk: '>=3.2.0 <4.0.0'
+  sdk: '>=3.5.0 <4.0.0'
 
 dependencies:
   path: ^1.8.3
 
 dev_dependencies:
-  leancode_lint: ^12.1.0
+  leancode_lint: ^14.2.0
diff --git a/dev/e2e_app/lib/main.dart b/dev/e2e_app/lib/main.dart
@@ -76,6 +76,9 @@ class _ExampleHomePageState extends State<ExampleHomePage> {
   @override
   Widget build(BuildContext context) {
     _appLinks.uriLinkStream.listen((uri) {
+      if (!context.mounted) {
+        return;
+      }
       Navigator.of(context).push(
         MaterialPageRoute<void>(
           builder: (_) => ApplinkScreen(