Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [video_player_android] Platform view support #3

Draft
wants to merge 93 commits into
base: feature/video-player-platform-view-support
Choose a base branch
from

Conversation

FirentisTFW
Copy link

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…w approach, like it happened up to this point
@FirentisTFW FirentisTFW force-pushed the feature/video-player-android-platform-view-support branch from 1cd8788 to 8dfc2e3 Compare December 17, 2024 12:14
@FirentisTFW FirentisTFW force-pushed the feature/video-player-android-platform-view-support branch from 8dfc2e3 to 8b203fc Compare December 17, 2024 12:16
@FirentisTFW FirentisTFW force-pushed the feature/video-player-android-platform-view-support branch from 2eda8cb to f41ff9a Compare December 17, 2024 16:27
FirentisTFW pushed a commit that referenced this pull request Dec 20, 2024
…r#8314)

Reverts flutter#6749

This is failing the publish step:

```
Running 'build_and_copy' in shared_preferences_tool
[build_and_copy] Building the extension Flutter web app...
Could not find an option named "--web-renderer".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
Unhandled exception:
ProcessException: Failed with exit code: 64
  Command: flutter build web --web-renderer canvaskit --pwa-strategy=offline-first --release --no-tree-shake-icons
#0      BuildExtensionCommand._runProcess (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:134:7)
<asynchronous suspension>
#1      BuildExtensionCommand.run (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:57:5)
<asynchronous suspension>
#2      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#3      SharedStdIn.terminate (package:io/src/shared_stdin.dart:91:3)
<asynchronous suspension>
#4      main (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/devtools_extensions.dart:16:3)
<asynchronous suspension>
```
@FirentisTFW FirentisTFW changed the title [DRAFT] [video_player_android] Feature/video player android platform view support [DRAFT] [video_player_android] Platform view support Dec 20, 2024
@FirentisTFW FirentisTFW force-pushed the feature/video-player-android-platform-view-support branch from 6297663 to 737f43f Compare December 20, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant