forked from flutter/packages
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] [video_player_android] Platform view support #3
Draft
FirentisTFW
wants to merge
93
commits into
feature/video-player-platform-view-support
Choose a base branch
from
feature/video-player-android-platform-view-support
base: feature/video-player-platform-view-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DRAFT] [video_player_android] Platform view support #3
FirentisTFW
wants to merge
93
commits into
feature/video-player-platform-view-support
from
feature/video-player-android-platform-view-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and platform view for each video
…w approach, like it happened up to this point
…ion for platform view
This reverts commit ea7e586.
FirentisTFW
force-pushed
the
feature/video-player-android-platform-view-support
branch
from
December 17, 2024 12:14
1cd8788
to
8dfc2e3
Compare
FirentisTFW
force-pushed
the
feature/video-player-android-platform-view-support
branch
from
December 17, 2024 12:16
8dfc2e3
to
8b203fc
Compare
FirentisTFW
force-pushed
the
feature/video-player-android-platform-view-support
branch
from
December 17, 2024 16:27
2eda8cb
to
f41ff9a
Compare
FirentisTFW
pushed a commit
that referenced
this pull request
Dec 20, 2024
…r#8314) Reverts flutter#6749 This is failing the publish step: ``` Running 'build_and_copy' in shared_preferences_tool [build_and_copy] Building the extension Flutter web app... Could not find an option named "--web-renderer". Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options. Unhandled exception: ProcessException: Failed with exit code: 64 Command: flutter build web --web-renderer canvaskit --pwa-strategy=offline-first --release --no-tree-shake-icons #0 BuildExtensionCommand._runProcess (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:134:7) <asynchronous suspension> #1 BuildExtensionCommand.run (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/_build_and_copy.dart:57:5) <asynchronous suspension> #2 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> #3 SharedStdIn.terminate (package:io/src/shared_stdin.dart:91:3) <asynchronous suspension> #4 main (file:///b/s/w/ir/x/w/.pub-cache/hosted/pub.dev/devtools_extensions-0.2.2/bin/devtools_extensions.dart:16:3) <asynchronous suspension> ```
FirentisTFW
changed the title
[DRAFT] [video_player_android] Feature/video player android platform view support
[DRAFT] [video_player_android] Platform view support
Dec 20, 2024
…ideo_player example app
FirentisTFW
force-pushed
the
feature/video-player-android-platform-view-support
branch
from
December 20, 2024 10:02
6297663
to
737f43f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.