Feature/additional loggers #7
Conversation
bartekpacia
force-pushed
the
feature/additional_loggers
branch
from
8f19110 to
5735404
Compare
lib/src/print_strategies.dart
Outdated
| import 'logging_bugfender.dart'; | ||
|
|
||
| /// Defines how [LoggingBugfenderListener] prints. | ||
| abstract class PrintStrategy { |
There was a problem hiding this comment.
I dont get it, why is it an interface and not just an enum?
There was a problem hiding this comment.
This strategy should have an abstract method that we actually can have various strategies on - creating the String log message.
There was a problem hiding this comment.
Initially I thought of adding some config options, for example to ColoredTextPrintStrategy. But yeah, this should be an enum.
There was a problem hiding this comment.
No. Refer to my comment below and what strategies are. :)
There was a problem hiding this comment.
I added my comment while yours @Albert221 was not visible. Sorry :) I totally agree.
lib/src/print_strategies.dart
Outdated
| import 'logging_bugfender.dart'; | ||
|
|
||
| /// Defines how [LoggingBugfenderListener] prints. | ||
| abstract class PrintStrategy { |
There was a problem hiding this comment.
This strategy should have an abstract method that we actually can have various strategies on - creating the String log message.
|
Somehow I can't get ASCII colors to work in VSCode terminal. TBH I'm a bit tired of it. I think that we can merge the current, basic version with 2 print strategies ( @Albert221 @shilangyu what do you think? I'd appreciate a review. |
|
@Albert221 it still says "changes requested" :) I'd appreciate your review |
Co-authored-by: Albert Wolszon <[email protected]>
Co-authored-by: Albert Wolszon <[email protected]>
fix #5 (see it for discussion)