Add linter rule to disallow string literals in Widget
classes
#261
+125
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260
This linter rule makes code review easier for internationalized apps, by preventing the usage of string literals in widgets.
This may be annoying, since we need string literals for things other than UI inside a widget's class, and it's not possible (at least from what I've seen from the analyzer API) to guarantee with a 100% certainty that they are being used in that context. As such, I added 2 simple exceptions:
Furthermore, there are some things we should discuss: